From: Baochen Qiang <quic_bqiang@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>, <mhi@lists.linux.dev>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH RFC v2 4/8] wifi: ath11k: remove MHI LOOPBACK channels
Date: Tue, 28 Nov 2023 09:13:26 +0800 [thread overview]
Message-ID: <7b833b76-13d2-4672-8f70-5ec681648c28@quicinc.com> (raw)
In-Reply-To: <20231127162022.518834-5-kvalo@kernel.org>
On 11/28/2023 12:20 AM, Kalle Valo wrote:
> From: Baochen Qiang <quic_bqiang@quicinc.com>
>
> There is no driver to match these two channels, so
> remove them. This fixes warnings from MHI subsystem during suspend:
>
> mhi mhi0_LOOPBACK: 1: Failed to reset channel, still resetting
> mhi mhi0_LOOPBACK: 0: Failed to reset channel, still resetting
With v2, these warnings are gone even without this patch. so it should
be removed from commit log. It's enough to only mention that those
channels are not used.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
> drivers/net/wireless/ath/ath11k/mhi.c | 56 ---------------------------
> 1 file changed, 56 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
> index afeabd6ecc67..579af57f7377 100644
> --- a/drivers/net/wireless/ath/ath11k/mhi.c
> +++ b/drivers/net/wireless/ath/ath11k/mhi.c
> @@ -21,34 +21,6 @@
> #define RDDM_DUMP_SIZE 0x420000
>
> static struct mhi_channel_config ath11k_mhi_channels_qca6390[] = {
> - {
> - .num = 0,
> - .name = "LOOPBACK",
> - .num_elements = 32,
> - .event_ring = 0,
> - .dir = DMA_TO_DEVICE,
> - .ee_mask = 0x4,
> - .pollcfg = 0,
> - .doorbell = MHI_DB_BRST_DISABLE,
> - .lpm_notify = false,
> - .offload_channel = false,
> - .doorbell_mode_switch = false,
> - .auto_queue = false,
> - },
> - {
> - .num = 1,
> - .name = "LOOPBACK",
> - .num_elements = 32,
> - .event_ring = 0,
> - .dir = DMA_FROM_DEVICE,
> - .ee_mask = 0x4,
> - .pollcfg = 0,
> - .doorbell = MHI_DB_BRST_DISABLE,
> - .lpm_notify = false,
> - .offload_channel = false,
> - .doorbell_mode_switch = false,
> - .auto_queue = false,
> - },
> {
> .num = 20,
> .name = "IPCR",
> @@ -114,34 +86,6 @@ static struct mhi_controller_config ath11k_mhi_config_qca6390 = {
> };
>
> static struct mhi_channel_config ath11k_mhi_channels_qcn9074[] = {
> - {
> - .num = 0,
> - .name = "LOOPBACK",
> - .num_elements = 32,
> - .event_ring = 1,
> - .dir = DMA_TO_DEVICE,
> - .ee_mask = 0x14,
> - .pollcfg = 0,
> - .doorbell = MHI_DB_BRST_DISABLE,
> - .lpm_notify = false,
> - .offload_channel = false,
> - .doorbell_mode_switch = false,
> - .auto_queue = false,
> - },
> - {
> - .num = 1,
> - .name = "LOOPBACK",
> - .num_elements = 32,
> - .event_ring = 1,
> - .dir = DMA_FROM_DEVICE,
> - .ee_mask = 0x14,
> - .pollcfg = 0,
> - .doorbell = MHI_DB_BRST_DISABLE,
> - .lpm_notify = false,
> - .offload_channel = false,
> - .doorbell_mode_switch = false,
> - .auto_queue = false,
> - },
> {
> .num = 20,
> .name = "IPCR",
next prev parent reply other threads:[~2023-11-28 1:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 16:20 [PATCH RFC v2 0/8] wifi: ath11k: hibernation support Kalle Valo
2023-11-27 16:20 ` [PATCH RFC v2 1/8] bus: mhi: host: add mhi_power_down_no_destroy() Kalle Valo
2023-11-30 5:42 ` Manivannan Sadhasivam
2023-12-01 1:08 ` Baochen Qiang
2023-12-05 12:29 ` Kalle Valo
2023-12-18 16:19 ` Jeff Johnson
2023-12-20 16:32 ` Manivannan Sadhasivam
2023-12-20 16:51 ` Manivannan Sadhasivam
2023-12-21 11:05 ` Baochen Qiang
2024-01-04 6:09 ` Manivannan Sadhasivam
2024-01-22 6:24 ` Manivannan Sadhasivam
2024-01-22 8:09 ` Baochen Qiang
2024-01-22 13:09 ` Manivannan Sadhasivam
2024-01-23 1:44 ` Baochen Qiang
2024-01-23 15:36 ` Manivannan Sadhasivam
2024-01-23 16:53 ` Jeff Johnson
2024-01-30 18:04 ` Manivannan Sadhasivam
2024-01-31 10:51 ` Baochen Qiang
2023-11-27 16:20 ` [PATCH RFC v2 2/8] bus: mhi: host: add new interfaces to handle MHI channels directly Kalle Valo
2024-01-30 18:19 ` Manivannan Sadhasivam
2024-01-31 7:39 ` Baochen Qiang
2024-02-01 10:00 ` Manivannan Sadhasivam
2024-02-02 6:42 ` Baochen Qiang
2024-02-02 7:10 ` Manivannan Sadhasivam
2024-02-02 10:49 ` Baochen Qiang
2024-02-02 12:16 ` Manivannan Sadhasivam
2023-11-27 16:20 ` [PATCH RFC v2 3/8] wifi: ath11k: handle irq enable/disable in several code path Kalle Valo
2023-11-27 16:20 ` [PATCH RFC v2 4/8] wifi: ath11k: remove MHI LOOPBACK channels Kalle Valo
2023-11-28 1:13 ` Baochen Qiang [this message]
2023-11-27 16:20 ` [PATCH RFC v2 5/8] wifi: ath11k: do not dump SRNG statistics during resume Kalle Valo
2023-11-27 16:20 ` [PATCH RFC v2 6/8] wifi: ath11k: fix warning on DMA ring capabilities event Kalle Valo
2023-11-27 16:20 ` [PATCH RFC v2 7/8] wifi: ath11k: thermal: don't try to register multiple times Kalle Valo
2023-11-27 16:20 ` [PATCH RFC v2 8/8] wifi: ath11k: support hibernation Kalle Valo
2023-11-27 18:49 ` [PATCH RFC v2 0/8] wifi: ath11k: hibernation support Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b833b76-13d2-4672-8f70-5ec681648c28@quicinc.com \
--to=quic_bqiang@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mhi@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).