linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kirtika Ruchandani <kirtika.ruchandani@gmail.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	Raja Mani <rmani@qti.qualcomm.com>,
	Michal Kazior <michal.kazior@tieto.com>
Subject: [PATCH 5/5] ath10k: Removed unused 'dev' in ath10k_ahb_resource_init
Date: Thu, 24 Nov 2016 00:02:43 -0800	[thread overview]
Message-ID: <7d837ab7846f83add2f5e289ece94d0dbeb82eed.1479974100.git.kirtika@chromium.org> (raw)
In-Reply-To: <cover.1479974100.git.kirtika@chromium.org>

Commit 704dc4e36769 introduced ath10k_ahb_resource_init() which
defines and sets 'struct device* dev' but does not use it.
Compiling with W=1 gives the following warning, fix it.

drivers/net/wireless/ath/ath10k/ahb.c: In function ‘ath10k_ahb_resource_init’:
drivers/net/wireless/ath/ath10k/ahb.c:449:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable]

This is a harmless warning, and is only being fixed to reduce the
noise with W=1 in the kernel.

Fixes: 704dc4e36769 ("ath10k: add resource init and deinit in ahb")
Cc: Raja Mani <rmani@qti.qualcomm.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org>
---
 drivers/net/wireless/ath/ath10k/ahb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index 8078d64..19507fe 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -443,12 +443,10 @@ static int ath10k_ahb_resource_init(struct ath10k *ar)
 {
	struct ath10k_ahb *ar_ahb = ath10k_ahb_priv(ar);
	struct platform_device *pdev;
-	struct device *dev;
	struct resource *res;
	int ret;

	pdev = ar_ahb->pdev;
-	dev = &pdev->dev;

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	if (!res) {
--
2.8.0.rc3.226.g39d4020

      parent reply	other threads:[~2016-11-24  8:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24  8:01 [PATCH 0/5] Fix -Wunused-but-set-variable in ath10k/ Kirtika Ruchandani
2016-11-24  8:01 ` [PATCH 1/5] ath10k: Remove unused 'buf_len' variable Kirtika Ruchandani
2017-01-18 14:37   ` [1/5] " Kalle Valo
2016-11-24  8:01 ` [PATCH 2/5] ath10k: Remove unused 'num_vdev_stats' variable Kirtika Ruchandani
2016-11-24  8:01 ` [PATCH 3/5] ath10k: Remove unused wmi_p2p_noa_descriptor 'noa' in wmi-tlv Kirtika Ruchandani
2016-11-24  9:50   ` Michal Kazior
2017-01-13 14:01   ` [3/5] " Kalle Valo
2016-11-24  8:02 ` [PATCH 4/5] ath10k: Removed unused 'dev' in ath10k_ahb_clock_enable() Kirtika Ruchandani
2016-11-24  8:02 ` Kirtika Ruchandani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d837ab7846f83add2f5e289ece94d0dbeb82eed.1479974100.git.kirtika@chromium.org \
    --to=kirtika.ruchandani@gmail.com \
    --cc=arnd@arndb.de \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmani@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).