From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: do not iterate active interfaces when in re-configure
Date: Thu, 30 Jul 2020 15:13:42 +0200 [thread overview]
Message-ID: <7f2722c9d30bb1a4715398b4f29309b1f383593b.camel@sipsolutions.net> (raw)
In-Reply-To: <c53fd2d0-3ffb-3700-f12e-34c1867dded4@candelatech.com>
On Thu, 2020-07-30 at 06:05 -0700, Ben Greear wrote:
> > It might even be that this can only be done subject to driver choice.
>
> I have tested this patch hard for many years with hundreds of station vifs on ath9k radios and
> 64 station vifs on ath10k radios, probably way harder than anyone else is testing
> this sort of thing.
Yeah, I'm sure!
> Possibly you are correct about iwlwifi, I've never tested it with multi-interface,
> and as you see, have had bad luck on ax200.
Right.
> If you'd accept a patch with a new driver flag check (which I can enable for
> ath10k and ath9k), then I'll respin it thus.
My order of preference would be something like
1. track per vif whether it was re-added, and skip before it is
If that works, I can certainly get behind it for semantic reasons (the
vif isn't yet active again), although even there I'm not sure how
iwlwifi would behave - but that's something I'd look into and perhaps
even consider a bug there since it shouldn't know about that interface
yet.
2. If for some reason that doesn't work, add an iteration flag that
controls this, rather than a per-device config?
johannes
next prev parent reply other threads:[~2020-07-30 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 16:53 [PATCH] mac80211: do not iterate active interfaces when in re-configure greearb
2020-07-30 11:48 ` Johannes Berg
2020-07-30 13:05 ` Ben Greear
2020-07-30 13:13 ` Johannes Berg [this message]
2020-07-30 13:27 ` Ben Greear
2020-07-30 13:41 ` Johannes Berg
2020-07-30 14:52 ` Ben Greear
2020-07-30 15:03 ` Johannes Berg
2020-09-16 22:28 ` Ben Greear
2020-09-21 8:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f2722c9d30bb1a4715398b4f29309b1f383593b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).