From: Christian Lamparter <chunkeey@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3] wireless: carl9170: fix LEDS build errors & warnings
Date: Sun, 30 May 2021 11:31:42 +0200 [thread overview]
Message-ID: <8043ff50-d592-7666-f001-7505efa0d4c2@gmail.com> (raw)
In-Reply-To: <20210530031134.23274-1-rdunlap@infradead.org>
On 30/05/2021 05:11, Randy Dunlap wrote:
> kernel test robot reports over 200 build errors and warnings
> that are due to this Kconfig problem when CARL9170=m,
> MAC80211=y, and LEDS_CLASS=m.
>
> WARNING: unmet direct dependencies detected for MAC80211_LEDS
> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
> Selected by [m]:
> - CARL9170_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && CARL9170 [=m]
>
> CARL9170_LEDS selects MAC80211_LEDS even though its kconfig
> dependencies are not met. This happens because 'select' does not follow
> any Kconfig dependency chains.
>
> Fix this by making CARL9170_LEDS depend on MAC80211_LEDS, where
> the latter supplies any needed dependencies on LEDS_CLASS.
Ok, this is not what I was expecting... I though you would just
add a "depends on / imply MAC80211_LEDS" on your v2. (this was
based on the assumption of what mac80211, ath9k/_htc and mt76
solutions of the same problem looked like).
But since (I assuming here) this patch passed the build-bots
testing with flying colors in the different config permutations.
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> Fixes: 1d7e1e6b1b8ed ("carl9170: Makefile, Kconfig files and MAINTAINERS")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Christian Lamparter <chunkeey@gmail.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> v2: modify as suggesed by Arnd
> v3: modify as suggested by Christian
>
> drivers/net/wireless/ath/carl9170/Kconfig | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> --- linux-next-20210528.orig/drivers/net/wireless/ath/carl9170/Kconfig
> +++ linux-next-20210528/drivers/net/wireless/ath/carl9170/Kconfig
> @@ -16,13 +16,11 @@ config CARL9170
>
> config CARL9170_LEDS
> bool "SoftLED Support"
> - depends on CARL9170
> - select MAC80211_LEDS
> - select LEDS_CLASS
> - select NEW_LEDS
> default y
> + depends on CARL9170
> + depends on MAC80211_LEDS
> help
> - This option is necessary, if you want your device' LEDs to blink
> + This option is necessary, if you want your device's LEDs to blink.
>
> Say Y, unless you need the LEDs for firmware debugging.
next prev parent reply other threads:[~2021-05-30 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 3:11 [PATCH v3] wireless: carl9170: fix LEDS build errors & warnings Randy Dunlap
2021-05-30 9:07 ` Arnd Bergmann
2021-05-30 9:31 ` Christian Lamparter [this message]
2021-05-30 14:32 ` Randy Dunlap
2021-06-03 9:46 ` Kalle Valo
2021-06-03 15:20 ` Randy Dunlap
2021-06-03 18:10 ` Christian Lamparter
2021-06-12 10:38 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8043ff50-d592-7666-f001-7505efa0d4c2@gmail.com \
--to=chunkeey@gmail.com \
--cc=arnd@arndb.de \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).