From: Wen Gong <wgong@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 7/9] mac80211: add parse transmit power envelope element
Date: Fri, 30 Jul 2021 18:16:01 +0800 [thread overview]
Message-ID: <80b779458e0edfb9c0f7194116b35286@codeaurora.org> (raw)
In-Reply-To: <ed5566ab47d271b845635b5c731938f333ee96b6.camel@sipsolutions.net>
On 2021-07-23 17:33, Johannes Berg wrote:
> On Mon, 2021-05-17 at 16:19 -0400, Wen Gong wrote:
>> This patch is to add the transmit power envelope element parse in
>> _ieee802_11_parse_elems_crc(), it maybe have more than one transmit
>> power envelope element in a beacon.
>
> This is really hard to read.
>
> I'm sure you're aware of
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_messages
>
> Also, FWIW, "This patch" language is pointless. We all know we're
> talking about a patch. Or maybe even not, we may be reading the commit
> later on.
will change it.
>
>> + case WLAN_EID_TX_POWER_ENVELOPE:
>> + if (elems->tx_pwr_env_num >=
>> ARRAY_SIZE(elems->tx_pwr_env))
>> + break;
>>
>
> Seems to me this should do some validation on the actual element? It at
> least has to have _one_ octet, afaict?
>
will change it.
> johannes
next prev parent reply other threads:[~2021-07-30 10:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 20:19 [PATCH 0/9] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-05-17 20:19 ` [PATCH 1/9] cfg80211: add power type definition for 6G Hz Wen Gong
2021-07-23 9:22 ` Johannes Berg
2021-05-17 20:19 ` [PATCH 2/9] mac80211: add definition of regulatory info in 6G Hz operation information Wen Gong
2021-05-17 20:19 ` [PATCH 3/9] mac80211: add parse " Wen Gong
2021-07-23 9:23 ` Johannes Berg
2021-05-17 20:19 ` [PATCH 4/9] cfg80211: add definition for 6G power spectral density(psd) Wen Gong
2021-07-23 9:24 ` Johannes Berg
2021-07-30 10:00 ` Wen Gong
2021-05-17 20:19 ` [PATCH 5/9] cfg80211: save power spectral density(psd) of regulatory rule Wen Gong
2021-07-23 9:27 ` Johannes Berg
2021-07-30 10:06 ` Wen Gong
2021-05-17 20:19 ` [PATCH 6/9] mac80211: add definition for transmit power envelope element Wen Gong
2021-07-23 9:29 ` Johannes Berg
2021-07-23 9:31 ` Johannes Berg
2021-07-30 10:27 ` Wen Gong
2021-05-17 20:19 ` [PATCH 7/9] mac80211: add parse " Wen Gong
2021-07-23 9:33 ` Johannes Berg
2021-07-30 10:16 ` Wen Gong [this message]
2021-05-17 20:19 ` [PATCH 8/9] mac80211: add transmit power envelope element and power constraint in bss_conf Wen Gong
2021-07-23 9:33 ` Johannes Berg
2021-05-17 20:19 ` [PATCH 9/9] mac80211: save transmit power envelope element and power constraint Wen Gong
2021-07-23 9:38 ` Johannes Berg
2021-07-30 10:47 ` Wen Gong
2021-08-03 8:53 ` Wen Gong
2021-08-13 7:19 ` Johannes Berg
2021-08-13 7:25 ` Johannes Berg
2021-08-13 8:47 ` Wen Gong
2021-08-13 8:53 ` Johannes Berg
2021-08-13 9:16 ` Wen Gong
2021-08-13 10:11 ` Johannes Berg
2021-08-13 10:29 ` Wen Gong
2021-08-13 8:13 ` Wen Gong
2021-05-25 10:04 ` [PATCH 0/9] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-06-15 8:52 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b779458e0edfb9c0f7194116b35286@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).