Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: <Ajay.Kathat@microchip.com>
To: <lkml@SDF.ORG>, <gregkh@linuxfoundation.org>
Cc: <Adham.Abozaeid@microchip.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wilc1000: Use crc7 in lib/ rather than a private copy
Date: Fri, 27 Mar 2020 07:03:28 +0000
Message-ID: <820cc7dd-b19e-fdb4-feec-c8595e6029ce@microchip.com> (raw)
In-Reply-To: <20200326192836.GB15115@SDF.ORG>

Hi George,

On 27/03/20 12:58 am, George Spelvin wrote:
> 
> The code in lib/ is the desired polynomial, and even includes
> the 1-bit left shift in the table rather than needing to code
> it explicitly.
> 
> While I'm in Kconfig, add a description of what a WILC1000 is.
> Kconfig questions that require me to look up a data sheet to
> find out that I probably don't have one are a pet peeve.
> 
> Signed-off-by: George Spelvin <lkml@sdf.org>
> Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
> Cc: Adham Abozaeid <adham.abozaeid@microchip.com>
> Cc: linux-wireless@vger.kernel.org
> ---
> v2: Rebase on staging-next tree
> v2: Resend to Greg.  I sent it to Ajay, maintainer of the driver, for
>     him to forward.  Should I have bypassed him?

Currently, wilc1000 driver is present in staging so while submitting
patches please mark 'devel@driverdev.osuosl.org' mail-id also.
Btw, I have already resubmitted your patch by adding mailing group. The
patch is applied to 'staging-next' branch, so please pull the latest
staging to check the changes.
For future patches, please also add 'devel@driverdev.osuosl.org' mailing-id.

Regards,
Ajay

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 19:28 George Spelvin
2020-03-27  7:03 ` Ajay.Kathat [this message]
2020-03-27 15:32   ` George Spelvin
  -- strict thread matches above, loose matches on Subject: below --
2020-03-22 12:04 [PATCH] " George Spelvin
2020-03-23  5:03 ` Ajay.Kathat
2020-03-23  6:45   ` George Spelvin
2020-03-23  8:22     ` Ajay.Kathat
2020-03-23 14:14       ` [PATCH v2] " George Spelvin
2020-03-23 16:29         ` Ajay.Kathat
2020-03-26 14:54         ` Ajay.Kathat
2020-03-26 14:57           ` Greg KH
2020-03-23 17:05       ` George Spelvin
2020-03-24  7:19         ` Ajay.Kathat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=820cc7dd-b19e-fdb4-feec-c8595e6029ce@microchip.com \
    --to=ajay.kathat@microchip.com \
    --cc=Adham.Abozaeid@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkml@SDF.ORG \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git