From: Daniel Borkmann <daniel@iogearbox.net>
To: Herbert Xu <herbert@gondor.apana.org.au>,
kernel test robot <lkp@intel.com>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Eric Biggers <ebiggers@kernel.org>,
"Theodore Y.Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-fscrypt@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org,
Ilya Dryomov <idryomov@gmail.com>, Xiubo Li <xiubli@redhat.com>,
Jeff Layton <jlayton@kernel.org>,
ceph-devel@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
"David S. Miller" <davem@davemloft.net>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Mat Martineau <martineau@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
linux-inte@web.codeaurora.org, grity@vger.kernel.org,
"Jason A.Donenfeld" <Jason@zx2c4.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org, David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org
Subject: Re: [PATCH] KEYS: Include linux/errno.h in linux/verification.h
Date: Mon, 28 Aug 2023 11:33:04 +0200 [thread overview]
Message-ID: <8481f02f-7dad-0459-bd2e-536ff8ab6896@iogearbox.net> (raw)
In-Reply-To: <ZOm5mX0+oUGzO3xh@gondor.apana.org.au>
Hi Herbert,
On 8/26/23 10:36 AM, Herbert Xu wrote:
> On Sat, Aug 26, 2023 at 02:58:48PM +0800, kernel test robot wrote:
>>
>> All errors (new ones prefixed by >>):
>>
>> In file included from fs/ubifs/auth.c:12:
>>>> include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'
>
> ---8<---
> Add inclusion of linux/errno.h as otherwise the reference to EINVAL
> may be invalid.
>
> Fixes: f3cf4134c5c6 ("bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308261414.HKw1Mrip-lkp@intel.com/
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/include/linux/verification.h b/include/linux/verification.h
> index f34e50ebcf60..cb2d47f28091 100644
> --- a/include/linux/verification.h
> +++ b/include/linux/verification.h
> @@ -8,6 +8,7 @@
> #ifndef _LINUX_VERIFICATION_H
> #define _LINUX_VERIFICATION_H
>
> +#include <linux/errno.h>
> #include <linux/types.h>
>
> /*
>
Looks good, do you plan to route this fix to Linus?
Thanks,
Daniel
next prev parent reply other threads:[~2023-08-28 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1qYl9s-006vDm-IW@formenos.hmeau.com>
2023-08-26 6:58 ` [PATCH 2/12] ubifs: Do not include crypto/algapi.h kernel test robot
2023-08-26 8:36 ` [PATCH] KEYS: Include linux/errno.h in linux/verification.h Herbert Xu
2023-08-28 9:33 ` Daniel Borkmann [this message]
2023-08-27 1:40 ` [PATCH 2/12] ubifs: Do not include crypto/algapi.h kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8481f02f-7dad-0459-bd2e-536ff8ab6896@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=Jason@zx2c4.com \
--cc=ayush.sawal@chelsio.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=grity@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=idryomov@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=keyrings@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-inte@web.codeaurora.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=martineau@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=richard@nod.at \
--cc=steffen.klassert@secunet.com \
--cc=tytso@mit.edu \
--cc=xiubli@redhat.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).