From: Daniel Mack <daniel@zonque.org>
To: Colin King <colin.king@canonical.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-wireless@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: st95hf: remove redundant pointers 'dev' and 'nfcddev'
Date: Sat, 21 Jul 2018 11:54:35 +0200 [thread overview]
Message-ID: <8599f87b-8d71-37bc-cfbf-278a3359cf0b@zonque.org> (raw)
In-Reply-To: <20180720182431.24353-1-colin.king@canonical.com>
On Friday, July 20, 2018 08:24 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointers 'dev' and 'nfcddev' are being assigned but are never used
> hence they are redundant and can be removed.
>
> Cleans up clang warnings:
> warning: variable 'dev' set but not used [-Wunused-but-set-variable]
> warning: variable 'nfcddev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This seems correct.
I am currently working on a bigger series of patches for this driver
that also touches code in the same area. I plan to post the series next
week. If this patch is applied until then, I can rebase my changes upon
it before sending.
Thanks,
Daniel
> ---
> drivers/nfc/st95hf/core.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c
> index a50a95cfcfd8..36ef0e905ba3 100644
> --- a/drivers/nfc/st95hf/core.c
> +++ b/drivers/nfc/st95hf/core.c
> @@ -781,9 +781,7 @@ static irqreturn_t st95hf_irq_thread_handler(int irq, void *st95hfcontext)
> int result = 0;
> int res_len;
> static bool wtx;
> - struct device *dev;
> struct device *spidevice;
> - struct nfc_digital_dev *nfcddev;
> struct sk_buff *skb_resp;
> struct st95hf_context *stcontext =
> (struct st95hf_context *)st95hfcontext;
> @@ -828,8 +826,6 @@ static irqreturn_t st95hf_irq_thread_handler(int irq, void *st95hfcontext)
> goto end;
> }
>
> - dev = &stcontext->nfcdev->dev;
> - nfcddev = stcontext->ddev;
> if (skb_resp->data[2] == WTX_REQ_FROM_TAG) {
> /* Request for new FWT from tag */
> result = st95hf_handle_wtx(stcontext, true, skb_resp->data[3]);
>
prev parent reply other threads:[~2018-07-21 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 18:24 [PATCH] nfc: st95hf: remove redundant pointers 'dev' and 'nfcddev' Colin King
2018-07-21 9:54 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8599f87b-8d71-37bc-cfbf-278a3359cf0b@zonque.org \
--to=daniel@zonque.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).