From: "Reizer, Eyal" <eyalr@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] wlcore: add missing nvs file name info for wilink8
Date: Thu, 20 Jul 2017 07:38:13 +0000 [thread overview]
Message-ID: <8665E2433BC68541A24DFFCA87B70F5B36408E3D@DFRE01.ent.ti.com> (raw)
In-Reply-To: <20170706062634.GL3730@atomide.com>
> >
> > On Wed, Jul 05, 2017 at 01:06:54AM -0700, Tony Lindgren wrote:
> > > > > Not sure if this really is a regression as we've always had a bog=
us
> > > > > wl1271-nvs.bin in linux-firmware.git. Sure would be nice to fix i=
t,
> > > > > but going back to using a generic wl1271-nvs.bin sure does not se=
em
> > > > > like a good long term fix to me :)
> > > > A lot of legacy here...
> > > > Wl1271-nvs has been used mainly with wilink6/7 and indeed was devic=
e
> specific
> > > > Holding calibration info etc.
> > > > When they started with wilink8 the device specific configuration th=
at was
> > > > Part of it has switched to wl18xx-conf.bin and using the wlaconf to=
ol for
> setting it.
> > > > Also there is no calibration specific info per device with wilink8 =
so the
> wl18xx-conf.bin
> > > > The only thing left in wl1271-nvs.bin for wilink8 was the mac addre=
ss
> override.
> > >
> > > And the default wl1271-nvs.bin sets the mac address to a bogus deadbe=
ef
> address,
> > > so it's wrong to use and totally broken for distros :(
> >
> > So use something like the following pseudo-code?
> >
> > if (fw->mac_address =3D=3D deadbeef) {
> > fw->mac_address =3D get_random_mac();
Deadbeef0000 is a valid mac address, so I suggest detecting it and warning
the user of the bogus (default) nvs but don't attempt to get a random mac
address for him as it has to many rules (registered oui addresses etc.)
> > dev_warn(dev, "Detected unconfigured wl1271-nvs.bin.\n"
> > "Your device will run with limited performance.\n"
> > "Please use ti-utils to configure your device.\n");
> > }
>=20
> Yeah something like that should do the trick :)
>=20
Seems logical, will submit a v3 using wl1271-nvs.bin for wl18xx while addin=
g this
Check/warn.
Best Regards,
Eyal
prev parent reply other threads:[~2017-07-20 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 10:54 [PATCH] wlcore: add missing nvs file name info for wilink8 Reizer, Eyal
2017-07-03 11:29 ` Kalle Valo
2017-07-04 8:17 ` Tony Lindgren
2017-07-04 8:46 ` Reizer, Eyal
2017-07-05 8:06 ` Tony Lindgren
2017-07-05 8:28 ` Sebastian Reichel
2017-07-06 6:26 ` Tony Lindgren
2017-07-20 7:38 ` Reizer, Eyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8665E2433BC68541A24DFFCA87B70F5B36408E3D@DFRE01.ent.ti.com \
--to=eyalr@ti.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).