From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Jonas Jelonek <jelonek.jonas@gmail.com>
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
nbd@nbd.name, Thomas Huehn <thomas.huehn@hs-nordhausen.de>
Subject: Re: [PATCH] ath9k: switch to rate table based lookup
Date: Fri, 26 Nov 2021 13:01:56 +0100 [thread overview]
Message-ID: <8735njazwr.fsf@toke.dk> (raw)
In-Reply-To: <CAChE-vT1UMw2iadzuzsUPEcAopi=86N4GV_b4=chZbSvap3x=A@mail.gmail.com>
Jonas Jelonek <jelonek.jonas@gmail.com> writes:
>> What's the practical implication of this? Performance benefits, better
>> rates selected, or what? Got any benchmark numbers?
>
> We're planning to annotate and implement 'transmit power control' per
> packet / per MRR
> and to improve the rate control API in mac80211 to support newer
> hardware.
Ah, great!
> SKB->CB is limited in space, tx power annotation also does not fit in
> there. Future
> perspective is that rate control won't use SKB->CB anymore, neither
> for normal rate
> setting nor for probing.
>
> The new rate control API (introduced with commit
> 0d528d85c519b755b6f4e1bafa3a39984370e1c1) allows drivers to directly
> get rates from sta->rates. This is not used by every driver yet,
> ieee80211_get_tx_rates performs the
> translation/merge for the drivers.
> The call to ieee80211_get_tx_rates and subsequent calls in ath9k can
> be avoided by directly fetching rates from sta->rates. This may also
> improve performance.
> ath9k does not expect rates in SKB->CB, therefore table merge does not
> need to consider this
> (except for first rate in SKB->CB for probing).
Please put something like the above explanation in the commit message so
people can understand the context. And as Kalle pointed out, some
information on how you tested this is also needed, and can go into the
commit message as well :)
-Toke
next prev parent reply other threads:[~2021-11-26 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 12:16 [PATCH] ath9k: switch to rate table based lookup Jonas Jelonek
2021-11-25 16:05 ` Toke Høiland-Jørgensen
2021-11-25 22:38 ` Jonas Jelonek
2021-11-26 12:01 ` Toke Høiland-Jørgensen [this message]
2021-11-26 7:07 ` Kalle Valo
[not found] ` <CAChE-vTktHRW1JR8s1NNnLOqfBihd=5T2qXDsQDyBeecw95U0g@mail.gmail.com>
2021-11-26 14:59 ` Kalle Valo
2021-11-26 18:33 ` Toke Høiland-Jørgensen
2021-11-29 8:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735njazwr.fsf@toke.dk \
--to=toke@redhat.com \
--cc=jelonek.jonas@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=thomas.huehn@hs-nordhausen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).