From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: Matthias Schiffer <mschiffer@universe-factory.net>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nbd@nbd.name" <nbd@nbd.name>
Subject: Re: [PATCH 1/3] ath9k: remove stray backslash in Makefile
Date: Thu, 7 Dec 2017 14:30:14 +0000 [thread overview]
Message-ID: <87374mvcej.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20171127193516.682827ea@cakuba.netronome.com> (Jakub Kicinski's message of "Mon, 27 Nov 2017 19:35:16 -0800")
Jakub Kicinski <kubakici@wp.pl> writes:
> On Mon, 27 Nov 2017 18:56:21 +0100, Matthias Schiffer wrote:
>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
>> ---
>> drivers/net/wireless/ath/ath9k/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wirel=
ess/ath/ath9k/Makefile
>> index 36a40ffdce15..90e4a341076c 100644
>> --- a/drivers/net/wireless/ath/ath9k/Makefile
>> +++ b/drivers/net/wireless/ath/ath9k/Makefile
>> @@ -59,7 +59,7 @@ obj-$(CONFIG_ATH9K_HW) +=3D ath9k_hw.o
>> obj-$(CONFIG_ATH9K_COMMON) +=3D ath9k_common.o
>> ath9k_common-y:=3D common.o \
>> common-init.o \
>> - common-beacon.o \
>> + common-beacon.o
>> =20
>
> It's not necessarily stray, there is nothing on the next line so it's
> OK, and if you add \ at the end of all lines, you don't have to touch
> the last line every time you add/remove something. Sort of like
> putting a , after last enum value.
I agree with Jakub, I think the backslash is there on purpose so I
dropped this patch.
--=20
Kalle Valo=
prev parent reply other threads:[~2017-12-07 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 17:56 [PATCH 1/3] ath9k: remove stray backslash in Makefile Matthias Schiffer
2017-11-27 17:56 ` [PATCH 2/3] ath9k: move spectral scan support under a separate config symbol Matthias Schiffer
2017-12-07 14:32 ` [2/3] " Kalle Valo
2017-11-27 17:56 ` [PATCH 3/3] ath10k: " Matthias Schiffer
2017-11-28 3:35 ` [PATCH 1/3] ath9k: remove stray backslash in Makefile Jakub Kicinski
2017-12-07 14:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87374mvcej.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=kubakici@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).