From: Kalle Valo <kvalo@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, stable@vger.kernel.org,
Peter Seiderer <ps.report@gmx.net>
Subject: Re: [PATCH v5.18] ath9k: Save rate counts before clearing tx status area
Date: Sat, 02 Apr 2022 20:45:50 +0300 [thread overview]
Message-ID: <874k3btm41.fsf@kernel.org> (raw)
In-Reply-To: <87lewnfwyg.fsf@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\?\= \=\?utf-8\?Q\?\=C3\=B8rgensen\=22's\?\= message of "Sat, 02 Apr 2022 15:15:19 +0200")
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
>> On Sat, 2022-04-02 at 14:27 +0200, Toke Høiland-Jørgensen wrote:
>>>
>>> @@ -2591,12 +2602,6 @@ static void ath_tx_rc_status(struct ath_softc *sc, struct ath_buf *bf,
>>> hw->max_rate_tries;
>>> }
>>>
>>> - for (i = tx_rateindex + 1; i < hw->max_rates; i++) {
>>
>> might want to drop that blank line too :)
>>
>>> - tx_info->status.rates[i].count = 0;
>>> - tx_info->status.rates[i].idx = -1;
>>> - }
>>> -
>>> - tx_info->status.rates[tx_rateindex].count = ts->ts_longretry + 1;
>>> }
>>
>> since there's nothing else.
>
> Hmm, fair point; Kalle, I don't suppose I could trouble you for a fixup
> when committing? :)
Sorry, editing the diff is more difficult for me. It would be easier if
you could submit v2.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-04-02 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 12:27 [PATCH v5.18] ath9k: Save rate counts before clearing tx status area Toke Høiland-Jørgensen
2022-04-02 12:31 ` Johannes Berg
2022-04-02 13:15 ` Toke Høiland-Jørgensen
2022-04-02 17:45 ` Kalle Valo [this message]
2022-04-03 13:23 ` Toke Høiland-Jørgensen
2022-04-02 12:40 ` Greg KH
2022-04-02 13:14 ` Toke Høiland-Jørgensen
2022-04-02 13:43 ` Greg KH
2022-04-04 16:11 ` Peter Seiderer
2022-04-04 17:27 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k3btm41.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ps.report@gmx.net \
--cc=stable@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).