From: Kalle Valo <kvalo@codeaurora.org>
To: Baochen Qiang <bqiang@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/7] ath11k: use ATH11K_PCI_IRQ_DP_OFFSET for DP IRQ
Date: Mon, 15 Nov 2021 12:31:21 +0200 [thread overview]
Message-ID: <874k8diubq.fsf@codeaurora.org> (raw)
In-Reply-To: <20211026041655.5112-1-bqiang@codeaurora.org> (Baochen Qiang's message of "Tue, 26 Oct 2021 12:16:55 +0800")
Baochen Qiang <bqiang@codeaurora.org> writes:
> From: Carl Huang <cjhuang@codeaurora.org>
>
> Like ATH11K_PCI_IRQ_CE0_OFFSET, define ATH11K_PCI_IRQ_DP_OFFSET for
> DP to save the IRQ instead of base_vector from MSI config.
>
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>
> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Baochen Qiang <bqiang@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath11k/pci.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c
> index bf8d34bc5afa..ed610e56c160 100644
> --- a/drivers/net/wireless/ath/ath11k/pci.c
> +++ b/drivers/net/wireless/ath/ath11k/pci.c
> @@ -16,7 +16,8 @@
> #define ATH11K_PCI_BAR_NUM 0
> #define ATH11K_PCI_DMA_MASK 32
>
> -#define ATH11K_PCI_IRQ_CE0_OFFSET 3
> +#define ATH11K_PCI_IRQ_CE0_OFFSET 3
> +#define ATH11K_PCI_IRQ_DP_OFFSET 14
>
> #define WINDOW_ENABLE_BIT 0x40000000
> #define WINDOW_REG_ADDRESS 0x310c
> @@ -764,7 +765,7 @@ static int ath11k_pci_ext_irq_config(struct ath11k_base *ab)
> }
>
> irq_grp->num_irq = num_irq;
> - irq_grp->irqs[0] = base_idx + i;
> + irq_grp->irqs[0] = ATH11K_PCI_IRQ_DP_OFFSET + i;
This broke the build, I fixed it in the pending branch:
drivers/net/wireless/ath/ath11k/pci.c: In function 'ath11k_pci_ext_irq_config':
drivers/net/wireless/ath/ath11k/pci.c:740:50: error: variable 'base_idx' set but not used [-Werror=unused-but-set-variable]
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-11-15 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 4:16 [PATCH 3/7] ath11k: use ATH11K_PCI_IRQ_DP_OFFSET for DP IRQ Baochen Qiang
2021-11-15 10:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k8diubq.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=bqiang@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).