From: Kalle Valo <kvalo@codeaurora.org>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Anilkumar Kolli <akolli@codeaurora.org>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 7/8] ath11k: add ce services for IPQ6018
Date: Mon, 15 Jun 2020 17:20:28 +0300 [thread overview]
Message-ID: <874krcjtqr.fsf@codeaurora.org> (raw)
In-Reply-To: <CAGRGNgWO_KwfQcfh=DSB5NdM2696ZzVU7ZuQN_x_+op1c5ySEw@mail.gmail.com> (Julian Calaby's message of "Tue, 9 Jun 2020 17:10:06 +1000")
Julian Calaby <julian.calaby@gmail.com> writes:
> On Tue, Jun 9, 2020 at 3:07 PM Anilkumar Kolli <akolli@codeaurora.org> wrote:
>>
>> IPQ6018 does not support mac2, add a new ce service map.
>>
>> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath11k/ahb.c | 122 ++++++++++++++++++++++++++++++++--
>> 1 file changed, 117 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
>> index b080ad8fab0a..25764f719db0 100644
>> --- a/drivers/net/wireless/ath/ath11k/ahb.c
>> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
>> @@ -647,8 +749,15 @@ static void ath11k_ahb_init_qmi_ce_config(struct ath11k_base *ab)
>>
>> cfg->tgt_ce_len = ARRAY_SIZE(target_ce_config_wlan) - 1;
>> cfg->tgt_ce = target_ce_config_wlan;
>> - cfg->svc_to_ce_map_len = ARRAY_SIZE(target_service_to_ce_map_wlan);
>> - cfg->svc_to_ce_map = target_service_to_ce_map_wlan;
>> + if (ab->hw_params.dev_id == ATH11K_HW_IPQ6018) {
>> + cfg->svc_to_ce_map_len =
>> + ARRAY_SIZE(target_service_to_ce_map_wlan_ipq6018);
>> + cfg->svc_to_ce_map = target_service_to_ce_map_wlan_ipq6018;
>> + } else {
>> + cfg->svc_to_ce_map_len =
>> + ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
>> + cfg->svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
>> + }
>
> You could just have a pointer to this array in the "hw_params"
> structure which would reduce this to something like:
>
> cfg->svc_to_ce_map_len = ARRAY_SIZE(ab->hw_params.service_to_ce_map);
> cfg->svc_to_ce_map = ab->hw_params.service_to_ce_map;
>
> and make adding future hardware easier.
Yeah, that's a good idea.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-06-15 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 5:03 [PATCH 0/8] ath11k: Add IPQ6018 support Anilkumar Kolli
2020-06-09 5:03 ` [PATCH 1/8] ath11k: update firmware files read path Anilkumar Kolli
2020-06-09 5:03 ` [PATCH 2/8] ath11k: rename default board file Anilkumar Kolli
2020-06-09 5:03 ` [PATCH 3/8] dt: bindings: net: update compatible for ath11k Anilkumar Kolli
2020-06-09 5:03 ` [PATCH 4/8] ath11k: add IPQ6018 support Anilkumar Kolli
2020-06-09 5:03 ` [PATCH 5/8] ath11k: define max_radios in hw_params Anilkumar Kolli
2020-06-09 5:03 ` [PATCH 6/8] ath11k: add hw_ops for pdev id to hw_mac mapping Anilkumar Kolli
2020-06-09 5:03 ` [PATCH 7/8] ath11k: add ce services for IPQ6018 Anilkumar Kolli
2020-06-09 7:10 ` Julian Calaby
2020-06-15 14:20 ` Kalle Valo [this message]
2020-06-09 5:03 ` [PATCH 8/8] ath11k: Add bdf-addr in hw_params Anilkumar Kolli
2020-06-09 6:43 ` [PATCH 0/8] ath11k: Add IPQ6018 support Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874krcjtqr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).