From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 05/11] iwlwifi: acpi: evaluate dsm to enable 5.2 bands in Indonesia
Date: Mon, 11 May 2020 14:47:27 +0300 [thread overview]
Message-ID: <874ksm66cw.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <iwlwifi.20200508170402.37266bcfa0a8.Iac74a6ffe45aff887cea13ee1d31b100ca11e249@changeid> (Luca Coelho's message of "Fri, 8 May 2020 17:07:56 +0300")
Luca Coelho <luca@coelho.fi> writes:
> From: Gil Adam <gil.adam@intel.com>
>
> Evaluate the appropriate DSM from ACPI to enable 5.15,5.35 GHz
> bands in Indonesia. If enabled send LARI_CONFIG_CHANGE cmd to fw.
>
> Signed-off-by: Gil Adam <gil.adam@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
[...]
> +static int iwl_mvm_eval_dsm_indonesia_5g2(struct iwl_mvm *mvm)
> +{
> + int ret = iwl_acpi_get_dsm_u8((&mvm->fwrt)->dev, 0,
> + DSM_FUNC_ENABLE_INDONESIA_5G2);
> +
> + IWL_DEBUG_RADIO(mvm,
> + "Evaluated DSM function ENABLE_INDONESIA_5G2, ret=%d\n",
> + ret);
> +
> + return ret == 1 ? 1 : 0;
Ugh. If it's _really_ important not to return anything bigger than 1
maybe "!!ret"? Or maybe even just change the function to return boolean?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-11 11:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 14:07 [PATCH 00/11] iwlwifi: updates intended for v5.8 2020-05-08 Luca Coelho
2020-05-08 14:07 ` [PATCH 01/11] iwlwifi: set NO_HE if the regulatory domain forbids it Luca Coelho
2020-05-08 16:41 ` Кирилл Луконин
2020-05-08 17:18 ` Luca Coelho
2020-05-08 20:10 ` Кирилл Луконин
2020-05-08 21:13 ` Luca Coelho
2020-05-08 21:21 ` Кирилл Луконин
2020-05-13 10:01 ` Кирилл Луконин
2020-05-08 14:07 ` [PATCH 02/11] iwlwifi: pcie: don't count on the FW to set persistence mode Luca Coelho
2020-05-08 14:07 ` [PATCH 03/11] iwlwifi: pcie: keep trans instead of trans_pcie in iwl_txq Luca Coelho
2020-05-08 14:07 ` [PATCH 04/11] iwlwifi: acpi: support device specific method (DSM) Luca Coelho
2020-05-11 11:43 ` Kalle Valo
2020-05-11 12:05 ` Luca Coelho
2020-05-08 14:07 ` [PATCH 05/11] iwlwifi: acpi: evaluate dsm to enable 5.2 bands in Indonesia Luca Coelho
2020-05-11 11:47 ` Kalle Valo [this message]
2020-05-11 12:08 ` Luca Coelho
2020-05-11 12:28 ` Luca Coelho
2020-05-08 14:07 ` [PATCH 06/11] iwlwifi: pcie: gen3: indicate 8k/12k RB size to device Luca Coelho
2020-05-08 14:07 ` [PATCH 07/11] iwlwifi: move iwl_txq and substructures to a common trans header Luca Coelho
2020-05-08 14:07 ` [PATCH 08/11] iwlwifi: move txq-specific from trans_pcie to common trans Luca Coelho
2020-05-08 14:08 ` [PATCH 09/11] iwlwifi: mvm: fix aux station leak Luca Coelho
2020-05-08 14:08 ` [PATCH 10/11] iwlwifi: mvm: add support for range request version 10 Luca Coelho
2020-05-08 14:08 ` [PATCH 11/11] iwlwifi: bump FW API to 56 for AX devices Luca Coelho
2020-05-29 6:39 [PATCH 00/11] iwlwifi: updates intended for v5.8 2020-05-08-2 Luca Coelho
2020-05-29 6:39 ` [PATCH 05/11] iwlwifi: acpi: evaluate dsm to enable 5.2 bands in Indonesia Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ksm66cw.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).