From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>
Subject: Re: pull-request: wireless-next-2024-02-20
Date: Thu, 22 Feb 2024 07:11:25 +0200 [thread overview]
Message-ID: <875xyhaxs2.fsf@kernel.org> (raw)
In-Reply-To: <20240221172521.4dcb382c@kernel.org> (Jakub Kicinski's message of "Wed, 21 Feb 2024 17:25:21 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> On Wed, 21 Feb 2024 17:18:41 -0800 Jeff Johnson wrote:
>> > definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the
>> > container for mac80211 hw")
>> >
>> > my setup is using gcc which isn't flagging this :(
>> >
>> > Karthikeyan, can you submit a patch?
>>
>> I see this was already fixed by:
>> 04edb5dc68f4 ("wifi: ath12k: Fix uninitialized use of ret in
>> ath12k_mac_allocate()")
>
> In wireless-next? Could you do a quick follow up PR so that
> it gets into net-next before the warning propagates into more
> of the networking sub-trees?
The fix is in ath-next but I'll pull ath-next into wireless-next and
then send a wireless-next pull request. So you should have the pull
request in few hours.
Sorry about this, I somehow understood this was a W=1 warning and didn't
prioritise the fix. After re-reading the commit message I can't
understand why I made that assumption, my bad.
What worries me is that the kbuild bot didn't warn this at all (or I
missed that as well). Is it using older clang version or what?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-22 5:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 16:58 pull-request: wireless-next-2024-02-20 Kalle Valo
2024-02-20 17:03 ` Kalle Valo
2024-02-21 11:51 ` patchwork-bot+netdevbpf
2024-02-21 22:35 ` Jakub Kicinski
2024-02-21 23:34 ` Jeff Johnson
2024-02-22 1:18 ` Jeff Johnson
2024-02-22 1:25 ` Jakub Kicinski
2024-02-22 5:11 ` Kalle Valo [this message]
2024-02-22 10:59 ` Kalle Valo
2024-02-22 23:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xyhaxs2.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).