From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D6CC4332F for ; Fri, 1 Oct 2021 12:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71DE1619EC for ; Fri, 1 Oct 2021 12:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354411AbhJAMlG (ORCPT ); Fri, 1 Oct 2021 08:41:06 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:48726 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354379AbhJAMlG (ORCPT ); Fri, 1 Oct 2021 08:41:06 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633091962; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=+LA/iPiXIb7Rh6nwCE/NZX+iTrBRh1ILVRGZiiUV9tQ=; b=k9UpxGEBMqXsGLqrempmL3NsRfHAVMYr6oqL0c37fCCJkld9T+4I8/p/Xjl5mvhJegQlE+di O/v5dKtxLdykLNcjlY17tN8JwTNYx5H81XRiVWZbrvHRXrlzHyRjBdhY6OCIiK93AsUnZ9db Nv0jMSLAZHgkKj6fc9JkjHH5Gdw= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 61570171a3e8d3c64013b6a3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 01 Oct 2021 12:39:13 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CB7C4C43616; Fri, 1 Oct 2021 12:39:12 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B2F4FC4338F; Fri, 1 Oct 2021 12:39:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org B2F4FC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Jerome Pouiller Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "David S . Miller" , devicetree@vger.kernel.org, Rob Herring , linux-mmc@vger.kernel.org, Pali =?utf-8?Q?Roh?= =?utf-8?Q?=C3=A1r?= , Ulf Hansson Subject: Re: [PATCH v7 09/24] wfx: add hwio.c/hwio.h References: <20210920161136.2398632-1-Jerome.Pouiller@silabs.com> <20210920161136.2398632-10-Jerome.Pouiller@silabs.com> <87k0ixkr6z.fsf@codeaurora.org> Date: Fri, 01 Oct 2021 15:39:03 +0300 In-Reply-To: <87k0ixkr6z.fsf@codeaurora.org> (Kalle Valo's message of "Fri, 01 Oct 2021 12:52:20 +0300") Message-ID: <875yug6hso.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: >> --- /dev/null >> +++ b/drivers/net/wireless/silabs/wfx/hwio.h >> @@ -0,0 +1,79 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Low-level I/O functions. >> + * >> + * Copyright (c) 2017-2020, Silicon Laboratories, Inc. >> + * Copyright (c) 2010, ST-Ericsson >> + */ >> +#ifndef WFX_HWIO_H >> +#define WFX_HWIO_H >> + >> +#include >> + >> +struct wfx_dev; >> + >> +/* Caution: in the functions below, 'buf' will used with a DMA. So, it must be >> + * kmalloc'd (do not use stack allocated buffers). In doubt, enable >> + * CONFIG_DEBUG_SG to detect badly located buffer. >> + */ >> +int wfx_data_read(struct wfx_dev *wdev, void *buf, size_t buf_len); >> +int wfx_data_write(struct wfx_dev *wdev, const void *buf, size_t buf_len); >> + >> +int sram_buf_read(struct wfx_dev *wdev, u32 addr, void *buf, size_t len); >> +int sram_buf_write(struct wfx_dev *wdev, u32 addr, const void *buf, size_t len); >> + >> +int ahb_buf_read(struct wfx_dev *wdev, u32 addr, void *buf, size_t len); >> +int ahb_buf_write(struct wfx_dev *wdev, u32 addr, const void *buf, size_t len); >> + >> +int sram_reg_read(struct wfx_dev *wdev, u32 addr, u32 *val); >> +int sram_reg_write(struct wfx_dev *wdev, u32 addr, u32 val); >> + >> +int ahb_reg_read(struct wfx_dev *wdev, u32 addr, u32 *val); >> +int ahb_reg_write(struct wfx_dev *wdev, u32 addr, u32 val); > > "wfx_" prefix missing from these functions. I actually saw quite a few functions without wfx_ prefix. My preference is that all function names would have that prefix. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches