From: Kalle Valo <kvalo@codeaurora.org>
To: Greg KH <greg@kroah.com>
Cc: Nguyen Dinh Phi <phind.uet@gmail.com>,
johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
Date: Sat, 31 Jul 2021 10:53:28 +0300 [thread overview]
Message-ID: <877dh6dimf.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <YQKELjKuAQsjmpLY@kroah.com> (Greg KH's message of "Thu, 29 Jul 2021 12:34:22 +0200")
Greg KH <greg@kroah.com> writes:
> On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
>> When we exceed the limit of BSS entries, this function will free the
>> new entry, however, at this time, it is the last door to access the
>> inputed ies, so these ies will be unreferenced objects and cause memory
>> leak.
>> Therefore we should free its ies before deallocating the new entry, beside
>> of dropping it from hidden_list.
>>
>> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
[...]
> Did this change get lost somewhere?
Johannes applied it to the macc80211 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=f9a5c358c8d26fed0cc45f2afc64633d4ba21dff
Ah, and it's already in Linus' tree as well.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-07-31 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 13:23 [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update Nguyen Dinh Phi
2021-07-29 10:34 ` Greg KH
2021-07-31 7:53 ` Kalle Valo [this message]
2021-07-31 8:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dh6dimf.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phind.uet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).