From: Kalle Valo <kvalo@kernel.org>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Luca Coelho <luca@coelho.fi>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH for v5.17 1/2] iwlwifi: remove deprecated broadcast filtering feature
Date: Mon, 31 Jan 2022 13:12:20 +0200 [thread overview]
Message-ID: <87a6fccg6j.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <b784b942-6346-7005-b71a-5682cf0452b1@leemhuis.info> (Thorsten Leemhuis's message of "Mon, 31 Jan 2022 09:08:00 +0100")
Thorsten Leemhuis <regressions@leemhuis.info> writes:
> Hi, this is your Linux kernel regression tracker speaking.
>
> On 28.01.22 13:48, Luca Coelho wrote:
>> From: Luca Coelho <luciano.coelho@intel.com>
>>
>> This feature has been deprecated and should not be used anymore. With
>> newer firmwares, namely *-67.ucode and above, trying to use it causes an
>> assertion failure in the FW, similar to this:
>>
>> [Tue Jan 11 20:05:24 2022] iwlwifi 0000:04:00.0: 0x00001062 | ADVANCED_SYSASSERT
>>
>> In order to prevent this feature from being used, remove it entirely
>> and get rid of the Kconfig option that
>> enables it (IWLWIFI_BCAST_FILTERING).
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215488
>
> FWIW there was another report about it afaics:
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215550
If it's the same issue, it should be marked as a duplicate.
> That makes me hope that this is reviewed and merged to mainline relative
> quickly, otherwise more users will be bothered by this.
>
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> Fixes: cbaa6aeedee5 ("iwlwifi: bump FW API to 67 for AX devices")
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>
> Shouldn't this also have:
>
> Cc: stable@vger.kernel.org # 5.16.x
I can add that.
BTW, please trim your quotes. You left a really long (and unnecessary)
quote, which makes use of patchwork much harder for us maintainers.
Unfortunately patchwork is not able to trim them automatically:
https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.20220128144623.9241e049f13e.Ia4f282813ca2ddd24c13427823519113f2bbebf2@changeid/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-01-31 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 12:48 [PATCH for v5.17 0/2] iwlwifi: fixes intended for v5.17 2022-01-28 part 2 Luca Coelho
2022-01-28 12:48 ` [PATCH for v5.17 1/2] iwlwifi: remove deprecated broadcast filtering feature Luca Coelho
2022-01-31 8:08 ` Thorsten Leemhuis
2022-01-31 11:12 ` Kalle Valo [this message]
2022-01-31 12:45 ` Thorsten Leemhuis
2022-02-03 9:02 ` Kalle Valo
2022-02-04 9:38 ` Thorsten Leemhuis
2022-02-03 8:26 ` [for,v5.17,1/2] " Kalle Valo
2022-01-28 12:48 ` [PATCH for v5.17 2/2] iwlwifi: mvm: don't send SAR GEO command for 3160 devices Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6fccg6j.fsf@tynnyri.adurom.net \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=regressions@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).