From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E78DC433E1 for ; Mon, 17 Aug 2020 13:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B26B2072D for ; Mon, 17 Aug 2020 13:28:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="eAvLkRrh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728665AbgHQN1z (ORCPT ); Mon, 17 Aug 2020 09:27:55 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:48846 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728650AbgHQN1z (ORCPT ); Mon, 17 Aug 2020 09:27:55 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597670874; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=INTxAt5lNz/SJ0qOc87ualrdr+KyL5wjMAo0+q1t93w=; b=eAvLkRrhXx66upx1NaO5+xNXEnBxjDW1U6CxZ0FjBVivcM6LH+QuSedgATIU/NwS40htRvNO RSDEOxKqDQdGQMCaWKj6XtV7TvvOS8+SZGRSFmD9pU3L4dVxhtKOzEmeLe6HIxNqvwg/SoYR MCNSKmJ/TadxsVwm0dp7xjXM+rc= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n10.prod.us-east-1.postgun.com with SMTP id 5f3a85acf2b697637a049001 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 17 Aug 2020 13:27:08 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 17D74C433AD; Mon, 17 Aug 2020 13:27:06 +0000 (UTC) Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 259DAC433CA; Mon, 17 Aug 2020 13:27:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 259DAC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, Benjamin Reed , Javier Achirica , Jean Tourrilhes , Fabrice Bellet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Ondrej Zary Subject: Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues References: <20200814113933.1903438-1-lee.jones@linaro.org> <20200814113933.1903438-13-lee.jones@linaro.org> <87r1s9l0mc.fsf@codeaurora.org> <20200814163831.GN4354@dell> Date: Mon, 17 Aug 2020 16:27:01 +0300 In-Reply-To: <20200814163831.GN4354@dell> (Lee Jones's message of "Fri, 14 Aug 2020 17:38:31 +0100") Message-ID: <87a6ytmmhm.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Lee Jones writes: > On Fri, 14 Aug 2020, Kalle Valo wrote: > >> Lee Jones writes: >> >> > - Ensure spaces appear after {for, if, while, etc} >> > - Ensure spaces to not appear after '(' >> > - Ensure spaces to not appear before ')' >> > - Ensure spaces appear between ')' and '{' >> > - Ensure spaces appear after ',' >> > - Ensure spaces do not appear before ',' >> > - Ensure spaces appear either side of '=' >> > - Ensure '{'s which open functions are on a new line >> > - Remove trailing whitespace >> > >> > There are still a whole host of issues with this file, but this >> > patch certainly breaks the back of them. >> > >> > Cc: Kalle Valo >> > Cc: "David S. Miller" >> > Cc: Jakub Kicinski >> > Cc: Benjamin Reed >> > Cc: Javier Achirica >> > Cc: Jean Tourrilhes >> > Cc: Fabrice Bellet >> > Cc: linux-wireless@vger.kernel.org >> > Cc: netdev@vger.kernel.org >> > Signed-off-by: Lee Jones >> > --- >> > drivers/net/wireless/cisco/airo.c | 897 ++++++++++++++++-------------- >> > 1 file changed, 467 insertions(+), 430 deletions(-) >> >> This is a driver for ancient hardware, I'm not sure if it's worth trying >> to fix any style issues. Is anyone even using it? Should we instead just >> remove the driver? > > Sounds like a reasonable solution to me. > > I'm also happy to do it, if there are no objections. > > As it stands, it's polluting the code-base and the build-log, so > something should be done. I tried to find some comments about the driver and here's one successful report from 2013: https://martybugs.net/wireless/aironet4800.cgi And here's one commit from 2015 where Ondrej (CCed) was also testing the driver: ---------------------------------------------------------------------- commit dae0412d0caa4948da07fe4ad91352b5b61a70ec Author: Ondrej Zary AuthorDate: Fri Oct 16 21:04:14 2015 +0200 Commit: Kalle Valo CommitDate: Wed Oct 28 20:54:39 2015 +0200 airo: fix scan after SIOCSIWAP (airo_set_wap) SIOCSIWAP (airo_set_wap) affects scan: only the AP specified by SIOCSIWAP is present in scan results. This makes NetworkManager work for the first time but then unable to find any other APs. Clear APList before starting scan and set it back after scan completes to work-around the problem. To avoid losing packets during scan, modify disable_MAC() to omit netif_carrier_off() call when lock == 2. Signed-off-by: Ondrej Zary Signed-off-by: Kalle Valo ---------------------------------------------------------------------- I was surprised to see that someone was using this driver in 2015, so I'm not sure anymore what to do. Of course we could still just remove it and later revert if someone steps up and claims the driver is still usable. Hmm. Does anyone any users of this driver? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches