From: Kalle Valo <kvalo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] wcn36xx: Fix multiple AMPDU sessions support
Date: Mon, 20 Jul 2020 17:19:32 +0300 [thread overview]
Message-ID: <87a6zu6zgr.fsf@codeaurora.org> (raw)
In-Reply-To: <CAMZdPi9kbcDha32Dy1w3ejS_nqmTQu1tXhGn8e20sfU8wzjLbQ@mail.gmail.com> (Loic Poulain's message of "Mon, 20 Jul 2020 16:17:02 +0200")
Loic Poulain <loic.poulain@linaro.org> writes:
> On Wed, 15 Jul 2020 at 17:33, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Loic Poulain <loic.poulain@linaro.org> wrote:
>
> > Several AMPDU sessions can be started, e.g. for different TIDs.
> > Currently the driver does not take care of the session ID when
> > requesting block-ack (statically set to 0), which leads to never
> > block-acked packet with sessions other than 0.
> >
> > Fix this by saving the session id when creating the ba session
> and
> > use it in subsequent ba operations.
> >
> > This issue can be reproduced with iperf in two steps (tid 0
> strem
> > then tid 6 stream).
> >
> > 1.0 iperf -s # wcn36xx side
> > 1.1 iperf -c ${IP_ADDR} # host side
> >
> > Then
> >
> > 2.0 iperf -s -u -S 0xC0 # wcn36xx side
> > 2.1 iperf -c ${IP_ADDR} -u -S 0xC0 -l 2000 # host side
> >
> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>
> What's the difference from the earlier version:
>
> https://patchwork.kernel.org/patch/11609871/
>
> A changelog would be nice.
>
>
> There is no change, but I've simply included it in this series.
> I can resend the series without this one if necessary so that you can
> consider only the initial one.
No need to resend, I just wanted to understand if there are any changes.
In the future try to always include a changelog, that way I don't need
to guess if something has changed or not.
And don't send HTML mail, linux-wireless list drops it and then your
mail won't be visible in the patchwork either.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-07-20 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 13:46 [PATCH 1/4] wcn36xx: Fix multiple AMPDU sessions support Loic Poulain
2020-06-30 13:46 ` [PATCH 2/4] wcn36xx: Add TX ack support Loic Poulain
2020-07-20 17:19 ` Kalle Valo
2020-07-21 10:16 ` Loic Poulain
2020-06-30 13:47 ` [PATCH 3/4] wcn36xx: Fix TX data path Loic Poulain
2020-06-30 13:47 ` [PATCH 4/4] wcn36xx: Fix software-driven scan Loic Poulain
2020-07-17 10:30 ` Bryan O'Donoghue
2020-07-15 15:33 ` [PATCH 1/4] wcn36xx: Fix multiple AMPDU sessions support Kalle Valo
[not found] ` <20200715153329.B95B6C433CA@smtp.codeaurora.org>
[not found] ` <CAMZdPi9kbcDha32Dy1w3ejS_nqmTQu1tXhGn8e20sfU8wzjLbQ@mail.gmail.com>
2020-07-20 14:19 ` Kalle Valo [this message]
2020-07-20 15:04 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6zu6zgr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).