From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C5E9ECE58E for ; Sun, 6 Oct 2019 08:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A9C92084B for ; Sun, 6 Oct 2019 08:23:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="fgEGxilU"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="fgEGxilU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbfJFIXP (ORCPT ); Sun, 6 Oct 2019 04:23:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49766 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbfJFIXP (ORCPT ); Sun, 6 Oct 2019 04:23:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6995A60907; Sun, 6 Oct 2019 08:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570350194; bh=sWOp4hj2K3mnGFtivA3C/9TKLdym8WLDeEHuJcCi3CA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fgEGxilU7PZDSgh/iA1d/qyLSAkD53WQLaZY+TabRbvIoi3JHVngruJdw7QRDXQWE kZDYzJpcB/TZ2xAgnxdWirgkjB34RhpBFNvyN8RndeSxG4TnnwRkl8Q3An+kXzmxJA nnCcd3/qF0YypaZNKEMjCFRu+l8ndqyxQslzT+Yc= Received: from x230.qca.qualcomm.com (37-33-18-250.bb.dnainternet.fi [37.33.18.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4553F601E7; Sun, 6 Oct 2019 08:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570350194; bh=sWOp4hj2K3mnGFtivA3C/9TKLdym8WLDeEHuJcCi3CA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fgEGxilU7PZDSgh/iA1d/qyLSAkD53WQLaZY+TabRbvIoi3JHVngruJdw7QRDXQWE kZDYzJpcB/TZ2xAgnxdWirgkjB34RhpBFNvyN8RndeSxG4TnnwRkl8Q3An+kXzmxJA nnCcd3/qF0YypaZNKEMjCFRu+l8ndqyxQslzT+Yc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4553F601E7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Johan Hovold Cc: Amitkumar Karwar , Siva Rebbagondla , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Denis Efremov Subject: Re: [PATCH 1/2] Revert "rsi: fix potential null dereference in rsi_probe()" References: <20191004144422.13003-1-johan@kernel.org> Date: Sun, 06 Oct 2019 11:23:10 +0300 In-Reply-To: <20191004144422.13003-1-johan@kernel.org> (Johan Hovold's message of "Fri, 4 Oct 2019 16:44:21 +0200") Message-ID: <87a7aes2oh.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johan Hovold writes: > This reverts commit f170d44bc4ec2feae5f6206980e7ae7fbf0432a0. > > USB core will never call a USB-driver probe function with a NULL > device-id pointer. > > Reverting before removing the existing checks in order to document this > and prevent the offending commit from being "autoselected" for stable. > > Signed-off-by: Johan Hovold I'll queue these two to v5.4. -- Kalle Valo