From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <tony0620emma@gmail.com>, <phhuang@realtek.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/7] wifi: rtw88: add port switch for AP mode
Date: Wed, 12 Apr 2023 15:35:18 +0300 [thread overview]
Message-ID: <87bkjt8eih.fsf@kernel.org> (raw)
In-Reply-To: <20230401124410.33221-3-pkshih@realtek.com> (Ping-Ke Shih's message of "Sat, 1 Apr 2023 20:44:05 +0800")
Ping-Ke Shih <pkshih@realtek.com> writes:
> From: Po-Hao Huang <phhuang@realtek.com>
>
> Switch port settings if AP mode does not start on port 0 because of
> hardware limitation. For some ICs, beacons on ports other than zero
> could misbehave and do not issue properly, to fix this we change AP
> VIFs to port zero when multiple interfaces is active.
>
> Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
[...]
> +static void rtw_port_switch_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
> +{
> + struct rtw_iter_port_switch_data *iter_data = data;
> + struct rtw_dev *rtwdev = iter_data->rtwdev;
> + struct rtw_vif *rtwvif_target = (struct rtw_vif *)vif->drv_priv;
> + struct rtw_vif *rtwvif_ap = iter_data->rtwvif_ap;
> + const struct rtw_hw_reg *reg1, *reg2;
> +
> + if (rtwvif_target->port != RTW_PORT_0)
> + return;
> +
> + rtw_info(rtwdev, "AP port switch from %d -> %d\n", rtwvif_ap->port,
> + rtwvif_target->port);
This looks more like a debug message. In normal operations (after the
initialisation) the drivers should be quiet and only print messages when
something unexpected happens.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-04-12 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 12:44 [PATCH 0/7] wifi: rtw88: support single channel concurrency Ping-Ke Shih
2023-04-01 12:44 ` [PATCH 1/7] wifi: rtw88: add bitmap for dynamic port settings Ping-Ke Shih
2023-04-01 12:44 ` [PATCH 2/7] wifi: rtw88: add port switch for AP mode Ping-Ke Shih
2023-04-12 12:35 ` Kalle Valo [this message]
2023-04-01 12:44 ` [PATCH 3/7] wifi: rtw88: 8822c: extend reserved page number Ping-Ke Shih
2023-04-01 12:44 ` [PATCH 4/7] wifi: rtw88: disallow scan and PS during AP mode Ping-Ke Shih
2023-04-12 12:39 ` Kalle Valo
2023-04-14 12:21 ` Ping-Ke Shih
2023-04-01 12:44 ` [PATCH 5/7] wifi: rtw88: refine reserved page flow for " Ping-Ke Shih
2023-04-01 12:44 ` [PATCH 6/7] wifi: rtw88: prevent scan abort with other VIFs Ping-Ke Shih
2023-04-01 12:44 ` [PATCH 7/7] wifi: rtw88: 8822c: add iface combination Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkjt8eih.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).