From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <rafal.milecki@gmail.com>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V3 1/2] brcmfmac: modify __brcmf_err() to take bus as a parameter
Date: Wed, 06 Feb 2019 14:14:56 +0200 [thread overview]
Message-ID: <87bm3pru4f.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20190206112816.563-1-zajec5@gmail.com> (=?utf-8?Q?=22Rafa?= =?utf-8?Q?=C5=82_Mi=C5=82ecki=22's?= message of "Wed, 6 Feb 2019 12:28:15 +0100")
"Rafał Miłecki" <rafal.milecki@gmail.com> writes:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> So far __brcmf_err() was using pr_err() which didn't allow identifying
> device that was affected by an error. It's crucial for systems with more
> than 1 device supported by brcmfmac (a common case for home routers).
>
> This change allows passing struct brcmf_bus to the __brcmf_err(). That
> struct has been agreed to be the most common one. It allows accessing
> struct device easily & using dev_err() printing helper.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> ---
> V2: Add missing #include <linux/device.h>
> V3: Add #include "bus.h" to fix CONFIG_BRCM_TRACING=y compilation error:
> error: dereferencing pointer to incomplete type 'struct brcmf_bus'
Thanks, this compiles for me now. I also pushed this to w-d-next pending
branch to get more build coverage from kbuild bot.
--
Kalle Valo
next prev parent reply other threads:[~2019-02-06 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 11:28 [PATCH V3 1/2] brcmfmac: modify __brcmf_err() to take bus as a parameter Rafał Miłecki
2019-02-06 11:28 ` [PATCH V3 2/2] brcmfmac: pass bus to the __brcmf_err() in pcie.c Rafał Miłecki
2019-02-06 12:14 ` Kalle Valo [this message]
2019-02-08 15:23 ` [PATCH V3 1/2] brcmfmac: modify __brcmf_err() to take bus as a parameter Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm3pru4f.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rafal.milecki@gmail.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).