From: Kalle Valo <kvalo@codeaurora.org>
To: Sarada Prasanna Garnayak <sarada.prasanna.garnayak@intel.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver
Date: Thu, 13 Dec 2018 11:25:38 +0200 [thread overview]
Message-ID: <87bm5p93sd.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20181212180928.42117-1-sarada.prasanna.garnayak@intel.com> (Sarada Prasanna Garnayak's message of "Wed, 12 Dec 2018 23:39:28 +0530")
Sarada Prasanna Garnayak <sarada.prasanna.garnayak@intel.com> writes:
> Add support for getting and free association ID if the station
> association ID management handled by the WLAN driver/firmware.
>
> Add cfg80211 driver ops and nl80211 API and CMD to request
> the WLAN driver to assign an AID for a station during association
> and release the AID of the station from the WLAN driver/firmware
> station database on disassociation from the AP.
>
> Signed-off-by: Sarada Prasanna Garnayak <sarada.prasanna.garnayak@intel.com>
[...]
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -3183,6 +3183,12 @@ struct cfg80211_ftm_responder_stats {
> *
> * @get_ftm_responder_stats: Retrieve FTM responder statistics, if available.
> * Statistics should be cumulative, currently no way to reset is provided.
> + * @get_sta_aid: Get an AID for the station from the driver if AID assignment
> + * is managed by the WLAN driver/hardware/firmware.
> + *
> + * @free_sta_aid: Release the AID of the station from the station database
> + * on disassociation from the AP if AID assignment is managed by
> + * the WLAN driver/hardware/firmware.
> */
> struct cfg80211_ops {
> int (*suspend)(struct wiphy *wiphy, struct cfg80211_wowlan *wow);
> @@ -3492,6 +3498,11 @@ struct cfg80211_ops {
> int (*get_ftm_responder_stats)(struct wiphy *wiphy,
> struct net_device *dev,
> struct cfg80211_ftm_responder_stats *ftm_stats);
> +
> + int (*get_sta_aid)(struct wiphy *wiphy, struct net_device *dev,
> + u16 *sta_aid, const u8 *mac_addr);
If I'm reading this patch correctly it looks like sta_aid or mac_addr
(or even both?) can be NULL? How should the driver handle that? I didn't
see any mentions of this in the document.
--
Kalle Valo
next prev parent reply other threads:[~2018-12-13 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 18:09 [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver Sarada Prasanna Garnayak
2018-12-13 9:25 ` Kalle Valo [this message]
2018-12-13 10:23 ` Johannes Berg
2018-12-12 18:12 Sarada Prasanna Garnayak
2018-12-19 13:19 ` Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm5p93sd.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sarada.prasanna.garnayak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).