From: Kalle Valo <kvalo@codeaurora.org>
To: Luciano Coelho <luciano.coelho@intel.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-kernel@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi
Date: Wed, 03 Oct 2018 11:58:12 +0300 [thread overview]
Message-ID: <87bm8bjtjv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <2787bccf20b6f647de9f4cafae5fd223e771b167.camel@intel.com> (Luciano Coelho's message of "Wed, 03 Oct 2018 10:24:44 +0300")
Luciano Coelho <luciano.coelho@intel.com> writes:
>> +#if IS_ENABLED(CONFIG_BT_INTEL)
>> + if (firmware_unlock_func) {
>> + firmware_unlock_func();
>> + symbol_put(btintel_firmware_lock);
>> + firmware_lock_func = NULL;
>> + symbol_put(btintel_firmware_unlock);
>> + firmware_unlock_func = NULL;
>> + }
>> +#endif
>> + }
>> else
>> ret = iwl_pcie_load_given_ucode(trans, fw);
>>
>
> I'm not sure I like adding this BT-specific stuff here, especially not
> without a detailed explanation.
This looks like an ugly hack and the commit log tells nothing. This
really needs strong justifications to even consider doing something like
this.
--
Kalle Valo
prev parent reply other threads:[~2018-10-03 8:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 7:15 [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi Kai-Heng Feng
2018-10-03 7:24 ` Luciano Coelho
2018-10-03 7:27 ` Kai Heng Feng
2018-10-03 7:29 ` Matt Chen
2018-10-03 7:38 ` Kai Heng Feng
2018-10-03 18:25 ` Marcel Holtmann
2018-10-05 8:30 ` Kai Heng Feng
2018-11-09 0:08 ` João Paulo Rechi Vita
2018-11-09 0:11 ` João Paulo Rechi Vita
2018-11-09 7:49 ` Marcel Holtmann
[not found] ` <CA+A7VXXfdyLWMpNaEzUzDe6PiktOKb5oJrufYrGeTyXyXChQfw@mail.gmail.com>
2018-12-05 19:27 ` João Paulo Rechi Vita
2019-01-09 0:26 ` João Paulo Rechi Vita
2019-01-09 18:39 ` Emmanuel Grumbach
2019-01-10 1:29 ` João Paulo Rechi Vita
2018-10-03 8:58 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm8bjtjv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).