From: Kalle Valo <kvalo@codeaurora.org>
To: Maya Erez <qca_merez@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com
Subject: Re: [PATCH] wil6210: prevent external wmi commands during suspend flow
Date: Tue, 08 Dec 2015 16:58:28 +0200 [thread overview]
Message-ID: <87bna19ecr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1448350215-4202-1-git-send-email-qca_merez@qca.qualcomm.com> (Maya Erez's message of "Tue, 24 Nov 2015 09:30:15 +0200")
Maya Erez <qca_merez@qca.qualcomm.com> writes:
> In __wmi_send we check if fw is ready at the beginning of the function.
> While we wait for the completion of the previous command, system suspend
> can be invoked and reset the HW, causing __wmi_send to read from HW
> registers while it is not ready.
> Taking the wmi_mutex in the reset flow when setting the FW ready bit
> to zero will prevent the above race condition.
>
> Signed-off-by: Maya Erez <qca_merez@qca.qualcomm.com>
Applied, thanks.
--
Kalle Valo
prev parent reply other threads:[~2015-12-08 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 7:30 [PATCH] wil6210: prevent external wmi commands during suspend flow Maya Erez
2015-12-08 14:58 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bna19ecr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=qca_merez@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).