From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C672C4741F for ; Wed, 30 Sep 2020 08:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED9CE2074A for ; Wed, 30 Sep 2020 08:01:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="xixnRG9y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728389AbgI3IBm (ORCPT ); Wed, 30 Sep 2020 04:01:42 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:24722 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbgI3IBm (ORCPT ); Wed, 30 Sep 2020 04:01:42 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601452901; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=tlskTQ+EyYvIXFMiKIZ4RubO/8MhQ+hgxykvwjXt5W0=; b=xixnRG9ykd2UFtcbgmc/8ZBXC/iYkfk80fjTIvJT/YYVYvFn6g8S/V68gKU2EcHkYTF+Xfqy WdkJ0uSHw9IW1Li04ilZ5ja/7mJq8fm44d7X4a9AcP8XbKCoTfxgpdhKDYXVp6vX5+iAYkmt Jfqxja6aUw/THANz+j683Zv0XGw= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5f743b5c767da8a9bbc7b2f9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 30 Sep 2020 08:01:32 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 79705C433F1; Wed, 30 Sep 2020 08:01:32 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B9F2AC433CA; Wed, 30 Sep 2020 08:01:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B9F2AC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Leon Romanovsky Cc: Srinivasan Raju , mostafa.afgani@purelifi.com, "David S. Miller" , Jakub Kicinski , Mauro Carvalho Chehab , Rob Herring , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices References: <20200924151910.21693-1-srini.raju@purelifi.com> <20200928102008.32568-1-srini.raju@purelifi.com> <20200930051602.GJ3094@unreal> Date: Wed, 30 Sep 2020 11:01:27 +0300 In-Reply-To: <20200930051602.GJ3094@unreal> (Leon Romanovsky's message of "Wed, 30 Sep 2020 08:16:02 +0300") Message-ID: <87d023elrc.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Leon Romanovsky writes: >> diff --git a/drivers/net/wireless/purelifi/Kconfig > b/drivers/net/wireless/purelifi/Kconfig >> new file mode 100644 >> index 000000000000..ff05eaf0a8d4 >> --- /dev/null >> +++ b/drivers/net/wireless/purelifi/Kconfig >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +config WLAN_VENDOR_PURELIFI >> + bool "pureLiFi devices" >> + default y > > "N" is preferred default. In most cases that's true, but for WLAN_VENDOR_ configs 'default y' should be used. It's the same as with NET_VENDOR_. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches