From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Tony Chuang <yhchuang@realtek.com>,
Justin Capella <justincapella@gmail.com>,
Chris Chiu <chiu@endlessm.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rtw88: disable TX-AMSDU on 2.4G band
Date: Mon, 02 Mar 2020 15:43:40 +0200 [thread overview]
Message-ID: <87d09u7tyr.fsf@codeaurora.org> (raw)
In-Reply-To: <CA+ASDXMjx8oQzK61rNHwpkKykgS2v_o+HTUyXujY9VXYNiNfxQ@mail.gmail.com> (Brian Norris's message of "Thu, 20 Feb 2020 11:04:31 -0800")
Brian Norris <briannorris@chromium.org> writes:
> On Tue, Feb 11, 2020 at 6:56 PM Tony Chuang <yhchuang@realtek.com> wrote:
>> Module parameters are really good for me, too. But we've had discussion
>> before with Kalle and Brian, they both were trying hard to avoid module
>> parameters.
>
> My personal preference is to avoid module parameters when you can fix
> the defaults, and that module parameters should never be a workaround
> for fixing the default behavior.
>
> I don't think my above preference precludes module parameters: they
> can be useful as "extra debug knobs."
>
> But Kalle had a little more nuanced opinion here -- he didn't even
> want "debug knobs" for core 802.11 functionality, because (I may be
> paraphrasing) one person's "debug knob" easily becomes the next
> person's "required knob." Additionally, a mess of disorganized knobs
> can make maintenance difficult -- one can't really expect the average
> distribution to make a good selection on 100 different parameters; and
> for those that do tweak the parameters, it now creates a combinatoric
> mess to debug and triage user reports of "it's broken". I can respect
> all of those reasons too.
Exactly my thinking as well, thanks Brian for writing these out. We
should add this description "why module parameters are bad" to the wiki
to make it more visible :)
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-03-02 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 12:06 [PATCH] rtw88: disable TX-AMSDU on 2.4G band yhchuang
2020-02-07 2:21 ` Chris Chiu
2020-02-07 19:40 ` Justin Capella
2020-02-07 20:41 ` Brian Norris
[not found] ` <CAMrEMU93LScySw4mpidAC5pVHV_NOShP1_GMMsvsAk1QBhdJjQ@mail.gmail.com>
2020-02-07 20:53 ` Brian Norris
2020-02-08 10:09 ` Kalle Valo
[not found] ` <CAMrEMU-nM1O_iJPVgGg2pL6JYWMdRKdPGe5N2rkfOihdmTeMaw@mail.gmail.com>
2020-02-12 2:55 ` Tony Chuang
2020-02-20 19:04 ` Brian Norris
2020-03-02 13:43 ` Kalle Valo [this message]
2020-02-12 16:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d09u7tyr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=chiu@endlessm.com \
--cc=justincapella@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).