From: Kalle Valo <kvalo@codeaurora.org>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: linux-wireless@vger.kernel.org,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Andrey Shevchenko <ashevchenko@quantenna.com>,
Sergei Maksimenko <smaksimenko@quantenna.com>
Subject: Re: [PATCH 5/6] qtnfmac: add support for PTA configuration
Date: Mon, 30 Jul 2018 17:06:41 +0300 [thread overview]
Message-ID: <87d0v4stqm.fsf@codeaurora.org> (raw)
In-Reply-To: <20180531091102.28666-6-sergey.matyukevich.os@quantenna.com> (Sergey Matyukevich's message of "Thu, 31 May 2018 12:11:01 +0300")
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes:
> From: Andrey Shevchenko <ashevchenko@quantenna.com>
>
> Implement support for PTA (Packet Traffic Arbitration) configuration.
> The PTA mechanism is used to coordinate sharing of the medium between
> WiFi and other 2.4 wireless networks, e.g. Bluetooth or ZigBee.
>
> This patch implements core infrastructure and vendor specific commands
> to control PTA functionality in firmware.
And no description of the actual interface which would have helped with
the review.
Anyway, the vendor commands are pain and they just make me grumpy. The
original idea was that upstream drivers should not support them at all,
later we flexed the rules so that low level hardware specific interfaces
might be ok, for example we added one in wil6210.
If I would even consider applying a patch which adds a vendor command it
needs a really good commit log with a proper description of the actual
interface and good justifications why a generic nl80211 command won't
work. I don't see anything even remotely close here.
Sorry for being grumpy, I just hate these vendor commands. Especially
when I see that a generic nl80211 command has not even be consired at
all.
--
Kalle Valo
next prev parent reply other threads:[~2018-07-30 15:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 9:10 [PATCH 0/6] qtnfmac: enable more features Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 1/6] qtnfmac: implement net_device_ops callback to set MAC address Sergey Matyukevich
2018-06-27 15:54 ` [1/6] " Kalle Valo
[not found] ` <20180627155439.481E76034E@smtp.codeaurora.org>
2018-06-29 9:26 ` Sergey Matyukevich
2018-06-29 9:43 ` Kalle Valo
2018-06-29 12:03 ` Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 2/6] qtnfmac: enable source MAC address randomization support Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 3/6] qtnfmac: implement cfg80211 power management callback Sergey Matyukevich
2018-06-01 1:04 ` Igor Mitsyanko
2018-06-04 12:50 ` Sergey Matyukevich
2018-06-04 18:58 ` Igor Mitsyanko
2018-07-30 13:55 ` Kalle Valo
2018-07-30 14:12 ` Kalle Valo
2018-05-31 9:11 ` [PATCH 4/6] qtnfmac: enable multiple SSIDs scan support Sergey Matyukevich
2018-05-31 9:11 ` [PATCH 5/6] qtnfmac: add support for PTA configuration Sergey Matyukevich
2018-07-30 14:06 ` Kalle Valo [this message]
2018-07-31 11:42 ` Arend van Spriel
2018-08-01 8:23 ` Sergey Matyukevich
2018-08-04 22:19 ` Arend van Spriel
2018-08-05 15:22 ` Sergey Matyukevich
2018-08-05 21:34 ` Arend van Spriel
2018-08-01 8:25 ` Kalle Valo
2018-05-31 9:11 ` [PATCH 6/6] qtnfmac: implement basic WoWLAN support Sergey Matyukevich
2018-07-30 14:13 ` Kalle Valo
2018-07-31 9:59 ` Sergey Matyukevich
2018-08-01 8:38 ` Kalle Valo
2018-05-31 9:36 ` [PATCH 0/6] qtnfmac: enable more features Kalle Valo
2018-05-31 10:35 ` Sergey Matyukevich
2018-05-31 11:12 ` Kalle Valo
2018-06-01 1:08 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0v4stqm.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ashevchenko@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
--cc=smaksimenko@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).