From: Kalle Valo <kvalo@codeaurora.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
Ian Molton <ian@mnementh.co.uk>,
russianneuromancer <russianneuromancer@ya.ru>,
linux-wireless <linux-wireless@vger.kernel.org>,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [4.13 REGRESSION] Re: brcm43430 sdio wifi regression with 4.13-rc1
Date: Mon, 14 Aug 2017 18:46:46 +0300 [thread overview]
Message-ID: <87d17yb195.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <2323972d-280f-048f-31fb-1c31b0228b22@redhat.com> (Hans de Goede's message of "Mon, 14 Aug 2017 17:20:38 +0200")
Hans de Goede <hdegoede@redhat.com> writes:
>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
>>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
>>> index d21258d..def120c 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
>>> @@ -159,8 +159,9 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)
>>>
>>> brcmf_feat_firmware_capabilities(ifp);
>>> memset(&gscan_cfg, 0, sizeof(gscan_cfg));
>>> - brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg",
>>> - &gscan_cfg, sizeof(gscan_cfg));
>>> + if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID)
>>> + brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN,
>>> "pfn_gscan_cfg",
>>> + &gscan_cfg, sizeof(gscan_cfg));
>>> brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_PNO, "pfn");
>>> if (drvr->bus_if->wowl_supported)
>>> brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_WOWL, "wowl");
>>>
>
> AFAICT this is still a problem with 4.13-rc5, can we at least get
> the above workaround merged for 4.13 ?
Just applied it few hours ago:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=e9bf53ab1ee34bb05c104bbfd2b77c844773f8e6
I'll try to get it to -rc6 but of course it depends on pull schedules if
it makes it or not.
--
Kalle Valo
next prev parent reply other threads:[~2017-08-14 15:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 18:43 brcm43430 sdio wifi regression with 4.13-rc1 Hans de Goede
2017-07-22 19:18 ` Ian Molton
2017-07-22 19:19 ` Ian Molton
2017-07-22 19:53 ` Arend van Spriel
2017-07-22 20:30 ` James Hughes
2017-07-23 7:08 ` Hans de Goede
2017-07-24 8:36 ` James Hughes
2017-08-14 15:20 ` [4.13 REGRESSION] " Hans de Goede
2017-08-14 15:46 ` Kalle Valo [this message]
2017-08-14 17:25 ` Hans de Goede
2017-07-22 21:33 ` Arend van Spriel
2017-08-02 20:43 ` russianneuromancer
2017-08-02 21:05 ` Arend van Spriel
2017-08-02 22:19 ` russianneuromancer
2017-08-09 15:42 ` russianneuromancer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d17yb195.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=ian@mnementh.co.uk \
--cc=linux-wireless@vger.kernel.org \
--cc=russianneuromancer@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).