From: Kalle Valo <kvalo@codeaurora.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: fetch (pre-)calibration data via nvmem subsystem
Date: Thu, 28 Oct 2021 11:58:13 +0300 [thread overview]
Message-ID: <87ee855xwa.fsf@codeaurora.org> (raw)
In-Reply-To: <20211016234609.1568317-1-chunkeey@gmail.com> (Christian Lamparter's message of "Sun, 17 Oct 2021 01:46:09 +0200")
Christian Lamparter <chunkeey@gmail.com> writes:
> ATH10K chips are used it wide range of routers,
> accesspoints, range extenders, network appliances.
> On these embedded devices, calibration data is often
> stored on the main system's flash and was out of reach
> for the driver.
>
> To bridge this gap, ath10k is getting extended to pull
> the (pre-)calibration data through nvmem subsystem.
> To do this, a nvmem-cell containing the information can
> either be specified in the platform data or via device-tree.
>
> Tested with:
> Netgear EX6150v2 (IPQ4018 - pre-calibration method)
> TP-Link Archer C7 v2 (QCA9880v2 - old calibration method)
>
> Cc: Robert Marko <robimarko@gmail.com>
> Cc: Thibaut VARÈNE <hacks@slashdirt.org>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>
> v1 -> v2:
> - use %zu and %u in the format string for size_t
> and u32 types (catched by the "kernel test robot").
> - reworded commit message + successfully tested on QCA9880v2
>
> I placed the nvmem code in front of the current "file" method
> (firmware_request). Reason is that this makes it easier for me
> to test it. If needed it can be moved to a different place.
Looks good to me. Before I apply this, I want to mention to that I have
had a long in my deferred queue related two patchsets:
https://patchwork.kernel.org/project/linux-wireless/patch/20200927192515.86-1-ansuelsmth@gmail.com/
https://patchwork.kernel.org/project/linux-wireless/patch/20200927192515.86-2-ansuelsmth@gmail.com/
https://patchwork.kernel.org/project/linux-wireless/patch/20200918181104.98-1-ansuelsmth@gmail.com/
https://patchwork.kernel.org/project/linux-wireless/patch/20200918181104.98-2-ansuelsmth@gmail.com/
Christian, we don't need those anymore, right? Expect the first patch
maybe.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-28 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 23:46 [PATCH v2] ath10k: fetch (pre-)calibration data via nvmem subsystem Christian Lamparter
2021-10-28 8:58 ` Kalle Valo [this message]
2021-10-28 11:31 ` Christian Lamparter
2021-10-28 11:39 ` Ansuel Smith
2021-10-28 11:52 ` Kalle Valo
2021-10-28 18:50 ` Christian Lamparter
2021-10-28 18:57 ` Ansuel Smith
2021-10-28 20:29 ` new "[1/2] ath10k: Try to get mac-address from dts" Christian Lamparter
2021-10-28 20:35 ` Ben Greear
2021-10-28 20:38 ` Ansuel Smith
2021-11-01 14:25 ` [PATCH v2] ath10k: fetch (pre-)calibration data via nvmem subsystem Kalle Valo
2021-11-01 14:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee855xwa.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=chunkeey@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).