From: Kalle Valo <kalle.valo@iki.fi>
To: Christian Lamparter <chunkeey@web.de>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFT] ar9170: downgrade BUG_ON() on unexpected mdpu
Date: Fri, 14 Aug 2009 20:11:32 +0300 [thread overview]
Message-ID: <87eire1fsr.fsf@litku.valot.fi> (raw)
In-Reply-To: <200908141150.54153.chunkeey@web.de> (Christian Lamparter's message of "Fri\, 14 Aug 2009 11\:50\:53 +0200")
Christian Lamparter <chunkeey@web.de> writes:
>> - BUG_ON(1);
>> - break;
>> + if (ar9170_nag_limiter(ar))
>> + printk(KERN_ERR "%s: rx'd unexpected "
>> + "type of MPDU.\n",
>> + wiphy_name(ar->hw->wiphy));
>> + return;
>> }
>
> no, this is really impossible! really!
A network driver should not have a BUG_ON(), stalling the whole system
is not acceptable. For example, with my current setup I would have no
idea why the system even crashed. WARN_ON() should be enough here.
--
Kalle Valo
prev parent reply other threads:[~2009-08-14 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 2:01 [RFT] ar9170: downgrade BUG_ON() on unexpected mdpu Luis R. Rodriguez
2009-08-14 9:50 ` Christian Lamparter
2009-08-14 15:30 ` Luis R. Rodriguez
2009-08-14 17:11 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eire1fsr.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).