From: Kalle Valo <kvalo@codeaurora.org>
To: Mark Herbert <mark.herbert42@gmail.com>
Cc: Wen Gong <quic_wgong@quicinc.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data
Date: Wed, 24 Nov 2021 11:44:09 +0200 [thread overview]
Message-ID: <87fsrl6g7q.fsf@codeaurora.org> (raw)
In-Reply-To: <871r3883q9.fsf@codeaurora.org> (Kalle Valo's message of "Mon, 22 Nov 2021 20:06:22 +0200")
Kalle Valo <kvalo@codeaurora.org> writes:
> Mark Herbert <mark.herbert42@gmail.com> writes:
>
>> Tried this on Dell XPS 13 9310
>>
>> Maybe this patch is good for 6855, but 6390 in Dell seems to be killed
>> completely with it. Reverting it makes things work again.
>>
>> [ 5.537034] ath11k_pci 0000:72:00.0: chip_id 0x0 chip_family 0xb
>> board_id 0xff soc_id 0xffffffff
>> [ 5.537038] ath11k_pci 0000:72:00.0: fw_version 0x101c06cc
>> fw_build_timestamp 2020-06-24 19:50 fw_build_id
>> [ 5.537236] ath11k_pci 0000:72:00.0: failed to fetch board data for
>> bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=DE_1901 from
>> ath11k/QCA6390/hw2.0/board-2.bin
>> [ 5.537255] ath11k_pci 0000:72:00.0: failed to fetch board-2.bin or
>> board.bin from QCA6390/hw2.0
>> [ 5.537257] ath11k_pci 0000:72:00.0: qmi failed to fetch board file: -2
>> [ 5.537258] ath11k_pci 0000:72:00.0: failed to load board data file: -2
>
> Doh, I didn't realise that. I only tested this on my NUC testbox, I
> should have tested this on my XPS 13 9310 as well. Thanks for the
> report!
>
> I think I need to revert this and rethink how to handle the backwards
> compatibility.
Revert sent:
https://patchwork.kernel.org/project/linux-wireless/patch/20211124094316.9096-1-kvalo@codeaurora.org/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-11-24 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 10:00 [PATCH v2] ath11k: add read variant from SMBIOS for download board data Wen Gong
2021-11-22 14:25 ` Kalle Valo
2021-11-22 14:35 ` Kalle Valo
2021-11-22 17:58 ` Mark Herbert
2021-11-22 18:06 ` Kalle Valo
2021-11-24 9:44 ` Kalle Valo [this message]
2021-11-25 8:55 ` Wen Gong
2021-11-24 10:07 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsrl6g7q.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.herbert42@gmail.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).