From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0273EC43331 for ; Sat, 28 Mar 2020 13:10:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC4AA20723 for ; Sat, 28 Mar 2020 13:10:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="QZ0XhFky" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbgC1NKa (ORCPT ); Sat, 28 Mar 2020 09:10:30 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:16787 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgC1NKa (ORCPT ); Sat, 28 Mar 2020 09:10:30 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585401030; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=BkP2Qzuch28mP0cczWwYlYUfLc1s1nSBvN5/FoexL4Q=; b=QZ0XhFkyCxg5wj633GkxStQfWllvFir2NFjZMNnSVb+yW28seFK6gKiU6IIpVPxV6qcnJiZI xUHooDuhBtYXsTZg5CaKK6lKo0W4sUjRCIcVz4fdWWfVT+xL2TEDGUlznRUXzHBx9VtktGC6 O00bKxdUQWx6MJdQ7GAmvsDHX1c= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7f4cbe.7ff8562435a8-smtp-out-n04; Sat, 28 Mar 2020 13:10:22 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1062CC433BA; Sat, 28 Mar 2020 13:10:22 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 08AF9C433F2; Sat, 28 Mar 2020 13:10:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 08AF9C433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Felipe Contreras Cc: Luca Coelho , linux-wireless Mailing List , Len Brown , noodles@earth.li Subject: Re: [PATCH v5.6] iwlwifi: don't send GEO_TX_POWER_LIMIT if no wgds table References: <20200323163858.A1183C44788@smtp.codeaurora.org> Date: Sat, 28 Mar 2020 15:10:15 +0200 In-Reply-To: (Felipe Contreras's message of "Sat, 28 Mar 2020 05:02:40 -0600") Message-ID: <87ftds1v7s.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felipe Contreras writes: > On Mon, Mar 23, 2020 at 10:42 AM Kalle Valo wrote: >> >> Luca Coelho wrote: >> >> > From: Golan Ben Ami >> > >> > The GEO_TX_POWER_LIMIT command was sent although >> > there is no wgds table, so the fw got wrong SAR values >> > from the driver. >> > >> > Fix this by avoiding sending the command if no wgds >> > tables are available. >> > >> > Signed-off-by: Golan Ben Ami >> > Fixes: 39c1a9728f93 ("iwlwifi: refactor the SAR tables from mvm to acpi") >> > Signed-off-by: Luca Coelho >> > Tested-By: Jonathan McDowell >> > Tested-by: Len Brown >> >> Patch applied to wireless-drivers.git, thanks. >> >> 0433ae556ec8 iwlwifi: don't send GEO_TX_POWER_LIMIT if no wgds table > > This should be applied to the stable tree, shouldn't it? 5.5 stable > releases have this issue. It's now in Linus' tree so I think you can just send a mail to the stable team and they will queue it. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches