From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [RESEND V2 3/4] ath11k: switch to using ieee80211_tx_status_ext()
Date: Tue, 11 Feb 2020 15:10:04 +0200 [thread overview]
Message-ID: <87h7zxxob7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200204151135.25302-3-john@phrozen.org> (John Crispin's message of "Tue, 4 Feb 2020 16:11:34 +0100")
John Crispin <john@phrozen.org> writes:
> This allows us to pass HE rates down into the stack.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
> drivers/net/wireless/ath/ath11k/dp_tx.c | 24 +++++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c
> index 7b532bf9acd8..66a6cfd54ad9 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_tx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
> @@ -357,9 +357,12 @@ static void ath11k_dp_tx_complete_msdu(struct ath11k *ar,
> struct sk_buff *msdu,
> struct hal_tx_status *ts)
> {
> + struct ieee80211_tx_status status = { 0 };
This adds a sparse warning:
drivers/net/wireless/ath/ath11k/dp_tx.c:350:47: warning: Using plain integer as NULL pointer
Seems like a false warning, no? But not sure how to shut up the warning,
using '{ NULL }' would do that but just feels wrong. Any opinions?
There was also a trivial checkpatch warning:
drivers/net/wireless/ath/ath11k/dp_tx.c:419: Please don't use multiple blank lines
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-02-11 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 15:11 [RESEND V2 1/4] ath11k: drop tx_info from ath11k_sta John Crispin
2020-02-04 15:11 ` [RESEND V2 2/4] ath11k: add HE rate accounting to driver John Crispin
2020-02-04 15:11 ` [RESEND V2 3/4] ath11k: switch to using ieee80211_tx_status_ext() John Crispin
2020-02-11 13:10 ` Kalle Valo [this message]
2020-02-11 14:38 ` Sven Eckelmann
2020-02-11 14:43 ` John Crispin
2020-02-12 15:55 ` Kalle Valo
2020-02-04 15:11 ` [PATCH 4/4] ath11k: add more HE fields into radiotap header John Crispin
2020-02-11 13:27 ` Kalle Valo
2020-02-11 18:30 ` [RESEND V2 1/4] ath11k: drop tx_info from ath11k_sta Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7zxxob7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).