From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5282C31E53 for ; Mon, 17 Jun 2019 07:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9CC921995 for ; Mon, 17 Jun 2019 07:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="aPPH25yI"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="aPPH25yI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726405AbfFQHoY (ORCPT ); Mon, 17 Jun 2019 03:44:24 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34880 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725826AbfFQHoX (ORCPT ); Mon, 17 Jun 2019 03:44:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E3E6460A44; Mon, 17 Jun 2019 07:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560757462; bh=Aenf+RXfbj5RyVkcFJ9IyGNg4Qewwd+uSbm54mHar40=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aPPH25yIRrzE1LFahKN8Lh5dxfRHYl+Y7UyF9Qm6o92zBPiSrNw6zj1DBg32PDrfa +bpio/2cwWakTG2A/aQpsZwRGKI8ZTVJb5lH7KUJvtNiskh4UTpOxNdJlP/g1KbtSB BToLNB+1clr0ByeaN2sdcGys3VY92ZSpMA0QkU+4= Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2A50A602DD; Mon, 17 Jun 2019 07:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560757462; bh=Aenf+RXfbj5RyVkcFJ9IyGNg4Qewwd+uSbm54mHar40=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aPPH25yIRrzE1LFahKN8Lh5dxfRHYl+Y7UyF9Qm6o92zBPiSrNw6zj1DBg32PDrfa +bpio/2cwWakTG2A/aQpsZwRGKI8ZTVJb5lH7KUJvtNiskh4UTpOxNdJlP/g1KbtSB BToLNB+1clr0ByeaN2sdcGys3VY92ZSpMA0QkU+4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2A50A602DD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Nick Desaulniers Cc: Nathan Huckleberry , eliad@wizery.com, arik@wizery.com, "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML , clang-built-linux Subject: Re: [PATCH] wl18xx: Fix Wunused-const-variable References: <20190614171713.89262-1-nhuck@google.com> Date: Mon, 17 Jun 2019 10:44:18 +0300 In-Reply-To: (Nick Desaulniers's message of "Fri, 14 Jun 2019 13:54:16 -0700") Message-ID: <87h88ofygd.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Nick Desaulniers writes: > On Fri, Jun 14, 2019 at 10:17 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: >> >> Clang produces the following warning >> >> drivers/net/wireless/ti/wl18xx/main.c:1850:43: warning: unused variable >> 'wl18xx_iface_ap_cl_limits' [-Wunused-const-variable] static const struct >> ieee80211_iface_limit wl18xx_iface_ap_cl_limits[] = { ^ >> drivers/net/wireless/ti/wl18xx/main.c:1869:43: warning: unused variable >> 'wl18xx_iface_ap_go_limits' [-Wunused-const-variable] static const struct >> ieee80211_iface_limit wl18xx_iface_ap_go_limits[] = { ^ >> >> The commit that added these variables never used them. Removing them. > > Previous thread, for context: > https://groups.google.com/forum/#!topic/clang-built-linux/1Lu1GT9ic94 > > Looking at drivers/net/wireless/ti/wl18xx/main.c, there 4 globally > declared `struct ieee80211_iface_limit` but as your patch notes, only > 2 are used. The thing is, their uses are in a `struct > ieee80211_iface_limit []`. > > Looking at > $ git blame drivers/net/wireless/ti/wl18xx/main.c -L 1850 > points to > commit 7845af35e0de ("wlcore: add p2p device support") > Adding Eliad and Arik to the thread; it's not clear to me what the > these variables were supposed to do, but seeing as the code in > question was already dead, this is no functional change from a user's > perspective. With that in mind: > Reviewed-by: Nick Desaulniers > > So I'd at least add the tag. > Fixes: 7845af35e0de ("wlcore: add p2p device support") I can't see any functional changes when applying this patch so I don't think a fixes line is needed, it's just cleanup. -- Kalle Valo