From: Kalle Valo <kvalo@adurom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luke-Jr <luke@dashjr.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] p54spi: replace internal "cx3110x" name with "p54spi"
Date: Sat, 31 Jul 2010 12:37:07 +0300 [thread overview]
Message-ID: <87iq3wdmbg.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1275640607.9953.15.camel@jlt3.sipsolutions.net> (Johannes Berg's message of "Fri\, 04 Jun 2010 10\:36\:47 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2010-06-02 at 14:06 -0500, Luke-Jr wrote:
>
>> > > .driver = {
>> > > - /* use cx3110x name because board-n800.c uses that for the
>> > > - * SPI port */
>> > > - .name = "cx3110x",
>> > > + .name = "p54spi",
>> > > .bus = &spi_bus_type,
>> >
>> > maybe that comment wasn't clear enough ... it needs to be that way to be
>> > properly linked up against SPI.
>>
>> I don't understand what you mean here. Does the hardware-side of SPI use
>> string identifiers? These are the only two instances of "cx3110x" in the
>> kernel source; N8x0 board files expect "p54spi"
>
> Hm, ok, I thought that the board stuff needed cx3110x. Hopefully it
> doesn't differ in n810s?
I changed the n8x0 board files (for both n800 and n810) in mainline to
use p54spi. So this patch is correct.
The old maemo kernels and the closed driver used cx3110x to identify
the spi device.
--
Kalle Valo
prev parent reply other threads:[~2010-07-31 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 2:16 [PATCH] p54spi: replace internal "cx3110x" name with "p54spi" Luke-Jr
2010-06-02 7:54 ` Johannes Berg
2010-06-02 19:06 ` Luke-Jr
2010-06-04 8:36 ` Johannes Berg
2010-07-31 9:37 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iq3wdmbg.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luke@dashjr.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).