From: Kalle Valo <kvalo@codeaurora.org>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: Johannes Berg <johannes@sipsolutions.net>, <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
ath11k@lists.infradead.org
Subject: Re: [PATCH -next] mac80111: fix build error without CONFIG_ATH11K_DEBUGFS
Date: Thu, 16 Jan 2020 15:45:56 +0200 [thread overview]
Message-ID: <87lfq7zf8r.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <943b570c-48f9-fe5b-1691-37539e3eeec8@huawei.com> (Chen Zhou's message of "Thu, 16 Jan 2020 21:35:44 +0800")
+ ath11k
Chen Zhou <chenzhou10@huawei.com> writes:
> Hi johannes,
>
> On 2020/1/16 20:59, Johannes Berg wrote:
>> On Thu, 2020-01-16 at 20:51 +0800, Chen Zhou wrote:
>>> If CONFIG_ATH11K_DEBUGFS is n, build fails:
>>>
>>> drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function ath11k_dbg_sta_open_htt_peer_stats:
>>> drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: struct ath11k has no member named debug
>>> ar->debug.htt_stats.stats_req = stats_req;
>>> ^~
>>> and many more similar messages.
>>>
>>> Select ATH11K_DEBUGFS under config MAC80211_DEBUGFS to fix this.
>>
>> Heh, no. You need to find a way in ath11 to fix this.
>
> In file drivers/net/wireless/ath/ath11k/Makefile, "ath11k-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o",
> that is, debugfs_sta only compiled when CONFIG_MAC80211_DEBUGFS is y.
>
> Any suggestions about this?
Arnd already fixed this:
https://patchwork.kernel.org/patch/11321921/
I'm planning to apply the patch soon.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-01-16 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 12:51 [PATCH -next] mac80111: fix build error without CONFIG_ATH11K_DEBUGFS Chen Zhou
2020-01-16 12:59 ` Johannes Berg
2020-01-16 13:35 ` Chen Zhou
2020-01-16 13:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfq7zf8r.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=chenzhou10@huawei.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).