From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694DFC77B6E for ; Fri, 14 Apr 2023 05:18:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbjDNFS2 (ORCPT ); Fri, 14 Apr 2023 01:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbjDNFS1 (ORCPT ); Fri, 14 Apr 2023 01:18:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87C251BF3 for ; Thu, 13 Apr 2023 22:18:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F304615A2 for ; Fri, 14 Apr 2023 05:18:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CC1DC433D2; Fri, 14 Apr 2023 05:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681449505; bh=0jfh+3jf1drwBWCy/08jc6sPYtyF0xx9YjsPtAEc8ys=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pgKaaAkvsJ0h++J7SoVft7yIFdVtqbR5H+O0bWh58dEUmNJyrQSMOlged5bDMwKcY xiVzkoXQm71mQ+VMAans1M9F82dq8HtyRruWVln1cApGkgcheKWUpqt6x1GggqxGG3 vlUmrBEcEskACPyEoa76sl9ftY5orTVz2UCgHAry1k5ywhBLas68j/z+KaOBScIas0 5doXbTge5cjztzkGq1wXoy9fXwh3ilH5r5WwgiDkPKLbpN30TGBjuTNzAUYkbL/fYA TrlZY+NpFD8B98UFNMoU6ZMDYWgyeNBKPRhemcrftAannf0rF72tzHQLYRFS2UHIL+ MoLrB368XutNA== From: Kalle Valo To: "Muna Sinada \(QUIC\)" Cc: Robert Marko , "ath11k\@lists.infradead.org" , "linux-wireless\@vger.kernel.org" , "Anilkumar Kolli \(QUIC\)" Subject: Re: [PATCH v2 2/4] wifi: ath11k: push MU-MIMO params from hostapd to hardware References: <1666128501-12364-1-git-send-email-quic_msinada@quicinc.com> <1666128501-12364-3-git-send-email-quic_msinada@quicinc.com> <87fs9ndh6s.fsf@kernel.org> <87bkkbdcfu.fsf@kernel.org> <87pm8iaggt.fsf@kernel.org> Date: Fri, 14 Apr 2023 08:18:21 +0300 In-Reply-To: (Muna Sinada's message of "Wed, 12 Apr 2023 23:19:49 +0000") Message-ID: <87mt3b6nz6.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Muna Sinada (QUIC)" writes: > Muna Sinada writes: >> Kalle Valo writes: >>> Robert Marko writes: >>> >>>> On Wed, Mar 29, 2023 at 11:45=E2=80=AFAM Kalle Valo = wrote: >>>> >>>>> >> @@ -5369,6 +5491,10 @@ static int ath11k_mac_copy_he_cap(struct=20 >>>>> >> ath11k *ar, >>>>> >> >>>>> >> he_cap_elem->mac_cap_info[1] &=3D >>>>> >>=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20 >>>>> >> IEEE80211_HE_MAC_CAP1_TF_MAC_PAD_DUR_MASK; >>>>> >> + he_cap_elem->phy_cap_info[0] &=3D >>>>> >> + ~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_1= 60MHZ_IN_5G; >>>>> >> + he_cap_elem->phy_cap_info[0] &=3D >>>>> >> +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 >>>>> >> + ~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_80PLUS80_MHZ_IN_5G; >>>>> > >>>>> > This is causing a regression for us in OpenWrt at least on IPQ8074= =20 >>>>> > but probably on all ath11k-supported HW. Cause 80+80 and 160MHz=20 >>>>> > support bits are being cleared here so 160MHz is not being=20 >>>>> > advertised after this patch. >>>>> >>>>> Oh man, not good. Robert, should we revert this patchset entirely?=20 >>>>> Of course it would be better if Muna can submit quickly a fix, but=20 >>>>> I'm not going to wait for long. >>>> >>>> I would prefer to see it get fixed, cause just removing the flag=20 >>>> removal gets 160MHz working, but I am not sure about other flags as=20 >>>> well. >>> >>> Ok, let's try to get it fixed then. Muna, can you comment and send a=20 >>> fix ASAP? >> >>No reply from Muna. I'll try the new bugbot to open a bug for this regres= sion: >> >>bugbot on > > I have created fix, tested it and pushed internally for review. > > @Kalle, how do I go about continuing the conversation on Bugzilla? Better to continue the discussion on the list. I only created the bug on Bugzilla so that I don't forget this as I didn't hear anything from you. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes