From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8D78C433DB for ; Thu, 25 Feb 2021 08:23:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AAC764F0A for ; Thu, 25 Feb 2021 08:23:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235772AbhBYIXE (ORCPT ); Thu, 25 Feb 2021 03:23:04 -0500 Received: from z11.mailgun.us ([104.130.96.11]:64784 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235669AbhBYIW4 (ORCPT ); Thu, 25 Feb 2021 03:22:56 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1614241357; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=mWa9QorkNUoGpvusbXo1SsHg51wVueK6wfZTgH3Vzs0=; b=B3yOr50PwLY2TMQoMDkTRQz4uoob1oq7uNMq06h6hhhCbacuWDK3c2TrdYranh1aAAPOHQwO YigQoTtVHdFVT0eOqqw5y9QlXbxMHj6AeB/arqOybq56Gk4UQvkjijJ9oPJDg2FO1gcL+k2j NwYmVQlpDPcnDKYVl74CyPDb1AA= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 60375e459a7cefa92a9346aa (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 25 Feb 2021 08:22:29 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 542DBC433ED; Thu, 25 Feb 2021 08:22:28 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5FB6AC433ED; Thu, 25 Feb 2021 08:22:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5FB6AC433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Cc: , , , Subject: Re: [PATCH 4/4] wilc1000: Add support for enabling CRC References: <20210224055135.1509200-1-davidm@egauge.net> <20210224055135.1509200-4-davidm@egauge.net> <70567db1d625086e051b305320c9d4be7deb1b82.camel@egauge.net> <74fcdef6-124e-3fc2-6467-f71badc01d0c@microchip.com> Date: Thu, 25 Feb 2021 10:22:24 +0200 In-Reply-To: <74fcdef6-124e-3fc2-6467-f71badc01d0c@microchip.com> (Ajay Kathat's message of "Thu, 25 Feb 2021 05:56:20 +0000") Message-ID: <87mtvseev3.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org writes: > On 25/02/21 5:06 am, David Mosberger-Tang wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> Julian, >> >> On Thu, 2021-02-25 at 08:19 +1100, Julian Calaby wrote: >>> Hi David, >>> >>> On Wed, Feb 24, 2021 at 6:56 PM David Mosberger-Tang < >>> davidm@egauge.net> wrote: >>>> >>>> +#define ENABLE_CRC7 0 /* set to 1 to protect SPI commands >>>> with CRC7 */ >>>> +#define ENABLE_CRC16 0 /* set to 1 to protect SPI data >>>> with CRC16 */ >>> >>> Should these be Kconfig variables instead? >> >> I'd certainly like that. Ajay, would you be OK with that? >> > > Yes, I am fine with the changes to move as Kconfig variable. Kconfig is not ideal for configuring functionality, something like a module parameter is usually better. But why not just enable CRC always? Why would the user need to disable this? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches