From: Kalle Valo <kvalo@codeaurora.org>
To: Xinming Hu <huxinming820@gmail.com>
Cc: Linux Wireless <linux-wireless@vger.kernel.org>,
Brian Norris <briannorris@google.com>,
Dmitry Torokhov <dtor@google.com>,
rajatja@google.com, Zhiyuan Yang <yangzy@marvell.com>,
Tim Song <songtao@marvell.com>, Cathy Luo <cluo@marvell.com>,
Xinming Hu <huxm@marvell.com>
Subject: Re: [PATCH] mwifiex: correct IE parse during association
Date: Fri, 28 Jul 2017 17:39:17 +0300 [thread overview]
Message-ID: <87mv7owrqi.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1500263187-1167-1-git-send-email-huxinming820@gmail.com> (Xinming Hu's message of "Mon, 17 Jul 2017 03:46:27 +0000")
Xinming Hu <huxinming820@gmail.com> writes:
> From: Xinming Hu <huxm@marvell.com>
>
> It is observed that some IEs get missed during association.
> This patch correct the old IE parse code. sme->ie will be
> store as wpa ie, wps ie, wapi ie and gen ie accordingly.
>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
> Signed-off-by: Cathy Luo <cluo@marvell.com>
[...]
> + } else {
> + if (pvendor_ie->element_id ==
> + WLAN_EID_VENDOR_SPECIFIC) {
> + /* Test to see if it is a WPA IE,
> + * if not, then it is a gen IE
> + */
> + if (!memcmp(pvendor_ie->oui, wpa_oui,
> + sizeof(wpa_oui))) {
> + /* IE is a WPA/WPA2 IE so call
> + * set_wpa function
> + */
> + mwifiex_set_wpa_ie(priv,
> + (u8 *)pvendor_ie,
> + cur_ie_len);
The indentation is getting ugly here. A helper function or similar would
really make this more readable.
[...]
> +NEXT_IE:
Goto labels in lower case, please.
--
Kalle Valo
next prev parent reply other threads:[~2017-07-28 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 3:46 [PATCH] mwifiex: correct IE parse during association Xinming Hu
2017-07-28 14:39 ` Kalle Valo [this message]
2017-07-31 9:51 ` Xinming Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv7owrqi.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=briannorris@google.com \
--cc=cluo@marvell.com \
--cc=dtor@google.com \
--cc=huxinming820@gmail.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rajatja@google.com \
--cc=songtao@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).