From: Kalle Valo <kvalo@codeaurora.org>
To: Wright Feng <wright.feng@cypress.com>
Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
brcm80211-dev-list@cypress.com,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
chi-hsien.lin@cypress.com, Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [PATCH] brcmfmac: reserve tx credit only when txctl is ready to send
Date: Thu, 13 Aug 2020 13:57:44 +0300 [thread overview]
Message-ID: <87o8nevmmv.fsf@codeaurora.org> (raw)
In-Reply-To: <20200813070017.89023-1-wright.feng@cypress.com> (Wright Feng's message of "Thu, 13 Aug 2020 02:00:16 -0500")
Wright Feng <wright.feng@cypress.com> writes:
> The 4329 throughput drops from 40.2 Mbits/sec to 190 Kbits/sec in 2G
> 11n mode because the commit b41c232d33666 ("brcmfmac: reserve 2 credits
> for host tx control path"). To fix the issue, host driver only reserves
> tx control credit when there is a txctl frame is pending to send. And
> we also check available credit by using "not equal to 0" instead of
> "greater than 0" because tx_max and tx_seq are circled positive numbers.
>
> Reported-by: Dmitry Osipenko <digetx@gmail.com>
> Fixes: b41c232d33666 ("brcmfmac: reserve 2 credits for host tx control
> path")
Fixes tag should be in one line, but I can fix it.
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
And I'll queue this to v5.9.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-13 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:00 [PATCH] brcmfmac: reserve tx credit only when txctl is ready to send Wright Feng
2020-08-13 10:57 ` Kalle Valo [this message]
2020-08-18 14:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8nevmmv.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=digetx@gmail.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).