From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] ath10k: drain tx before restarting hw
Date: Fri, 23 May 2014 11:27:01 +0300 [thread overview]
Message-ID: <87oayovr1m.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1400143324-14911-4-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 15 May 2014 10:42:02 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> This makes sure no further tx requests are
> submitted to HTT before driver teardown.
>
> This should prevent invalid pointer/NULL
> dereference on htt tx pool in ath10k_htt_tx() in
> some cases of heavy traffic.
>
> Reported-By: Ben Greear <greearb@candelatech.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -2289,6 +2289,21 @@ static void ath10k_tx(struct ieee80211_hw *hw,
> /*
> * Initialize various parameters with default vaules.
> */
> +static void ath10k_drain_tx(struct ath10k *ar)
> +{
> + /* workers can hold conf_mutex -- avoid deadlock */
> + WARN_ON(lockdep_is_held(&ar->conf_mutex));
If CONFIG_LOCKDEP is disabled this will fail with:
drivers/net/wireless/ath/ath10k/mac.c:2301:2: error: implicit declaration of function 'lockdep_is_held' [-Werror=implicit-function-declaration]
I wasn't able to come up with any other way than adding '#ifdef
CONFIG_LOCKDEP' which is quite ugly. What should we do?
--
Kalle Valo
next prev parent reply other threads:[~2014-05-23 8:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 12:15 [PATCH 0/5] ath10k: recovery fixes 2014-05-09 Michal Kazior
2014-05-09 12:15 ` [PATCH 1/5] ath10k: clean up start() callback Michal Kazior
2014-05-14 19:07 ` Kalle Valo
2014-05-09 12:15 ` [PATCH 2/5] ath10k: perform hw restart lazily Michal Kazior
2014-05-09 12:15 ` [PATCH 3/5] ath10k: drain tx before restarting hw Michal Kazior
2014-05-09 12:15 ` [PATCH 4/5] ath10k: protect wep tx key setup Michal Kazior
2014-05-14 19:17 ` Kalle Valo
2014-05-14 19:50 ` Kalle Valo
2014-05-15 6:04 ` Michal Kazior
2014-05-09 12:15 ` [PATCH 5/5] ath10k: dont configure bssid for ap mode Michal Kazior
2014-05-14 18:58 ` Kalle Valo
2014-05-15 8:41 ` [PATCH v2 0/5] ath10k: recovery fixes 2014-05-09 Michal Kazior
2014-05-15 8:42 ` [PATCH v2 1/5] ath10k: clean up start() callback Michal Kazior
2014-05-15 8:42 ` [PATCH v2 2/5] ath10k: perform hw restart lazily Michal Kazior
2014-05-15 8:42 ` [PATCH v2 3/5] ath10k: drain tx before restarting hw Michal Kazior
2014-05-15 13:18 ` Kalle Valo
2014-05-16 14:37 ` Kalle Valo
2014-05-23 8:27 ` Kalle Valo [this message]
2014-05-23 8:38 ` Michal Kazior
2014-05-23 8:45 ` Kalle Valo
2014-05-23 9:06 ` Michal Kazior
2014-05-23 10:31 ` Kalle Valo
2014-05-23 10:37 ` Michal Kazior
2014-05-23 13:03 ` Johannes Berg
2014-05-26 5:48 ` Michal Kazior
2014-05-26 6:29 ` Johannes Berg
2014-05-26 9:40 ` Kalle Valo
2014-05-26 9:43 ` Michal Kazior
2014-05-15 8:42 ` [PATCH v2 4/5] ath10k: protect wep tx key setup Michal Kazior
2014-05-15 8:42 ` [PATCH v2 5/5] ath10k: dont configure bssid for ap mode Michal Kazior
2014-05-27 9:29 ` [PATCH v2 0/5] ath10k: recovery fixes 2014-05-09 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oayovr1m.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).