From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B37AC43381 for ; Mon, 18 Feb 2019 19:21:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D16D21773 for ; Mon, 18 Feb 2019 19:21:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ihSsC6Gw"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="nTijeqdY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729399AbfBRTUz (ORCPT ); Mon, 18 Feb 2019 14:20:55 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35598 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729004AbfBRTUz (ORCPT ); Mon, 18 Feb 2019 14:20:55 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 60A0E608CD; Mon, 18 Feb 2019 19:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550517654; bh=FKs9GoTuE0katQgvbT+nWqLQ4yWk3UAeV0eWR/RsQRQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ihSsC6Gw0QxMI5MpEEPc3Fm+jrMexlJKuu+Rjvpti/zORD5dlywrZ2YFVTW06zU8P DzkMU+GpGJF+6ljuhdFy5oO9CZ3KwY0gzutAtlHG4NJbBdswRRB/e7smkQr7mr+Gtl 4//JtBFkaGTgC0Igxztk8wkND3uv4cvHkYMg63jU= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E555660740; Mon, 18 Feb 2019 19:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550517653; bh=FKs9GoTuE0katQgvbT+nWqLQ4yWk3UAeV0eWR/RsQRQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nTijeqdYPmkWKycQKI7SpkbO40N1gXlG+5P5p8TBmsz4+Zmc3muGbFYtY4/iAHRnd nHBgcKUiBaTLhYaZvgnRBN5wqIJQFpceyTbFcsV7ZajQXNf/dpL4um7o/au5uBCvLq WqZrecKhhmUAx0/SRj1ugtt2mWPTSb9cQKaTg9BE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E555660740 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Masahiro Yamada Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, linux-wireless@vger.kernel.org, Christoph Hellwig , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Bianconi , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Felix Fietkau , Matthias Brugger Subject: Re: [PATCH 1/2] wireless: mt76: call hweight8() instead of __sw_hweight8() References: <1550469571-25933-1-git-send-email-yamada.masahiro@socionext.com> <1550469571-25933-2-git-send-email-yamada.masahiro@socionext.com> <877edxt1f1.fsf@kamboji.qca.qualcomm.com> <87tvh0syq2.fsf@kamboji.qca.qualcomm.com> Date: Mon, 18 Feb 2019 21:20:46 +0200 In-Reply-To: <87tvh0syq2.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 18 Feb 2019 21:06:29 +0200") Message-ID: <87pnrosy29.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Kalle Valo writes: > >> Masahiro Yamada writes: >> >>> __sw_hweight8() is just internal implementation. >>> >>> Drivers should use the common API, hweight8(). >>> >>> Signed-off-by: Masahiro Yamada >> >> Acked-by: Kalle Valo >> >>> This patch should go to x86 tree along with 2/2. >>> >>> Otherwise, all{yes,mod}config of x86 would be broken. >>> >>> This patch is trivial enough. >>> I want ACK from the net/wireless maintainer >>> so that this can go in via x86 tree. >> >> Sounds good to me, feel free to push via the x86 tree. > > Actually, can you wait a bit? Felix just reminded me that we have a > similar patch pending from Ben Hutchings: > > https://patchwork.kernel.org/patch/10808203/ > > And it seems there are two instances of __sw_hweight8, at least in my > wireless-drivers-next tree: > > drivers/net/wireless/mediatek/mt76/mac80211.c: int i, nstream = > __sw_hweight8(dev->antenna_mask); > drivers/net/wireless/mediatek/mt76/mac80211.c: int n_chains = > __sw_hweight8(dev->antenna_mask); > > So we need to think what to do. I think the best would be that Felix applies Ben's patch to the wireless tree and I'll push it to Linus during the next merge window (via net-next). Simpler and less conflicts that way. So Masahiro, could you hold your x86 patch for a while until the mt76 patch will be in Linus' tree? That should not take more than two weeks, I think. -- Kalle Valo