linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org,
	Matti Gottlieb <matti.gottlieb@intel.com>
Subject: Re: [PATCH 2/2] iwlwifi: mvm: Fix paging memory leak
Date: Fri, 04 Mar 2016 18:07:51 +0200	[thread overview]
Message-ID: <87povaw7jc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1456433829-20285-2-git-send-email-emmanuel.grumbach@intel.com> (Emmanuel Grumbach's message of "Thu, 25 Feb 2016 22:57:09 +0200")

Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:

> From: Matti Gottlieb <matti.gottlieb@intel.com>
>
> If the opmode is stopped and started again we did not free
> the paging buffers. Fix that.
> In addition when freeing the firmware's paging download
> buffer, set the pointer to NULL.
>
> Signed-off-by: Matti Gottlieb <matti.gottlieb@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

Nitpicking while writing the pull request for Dave:

What does "opmode is stopped" mean? Important bug fixes should have a
clear bug description from user's point of view. Using driver internal
jargon is gibberish to most people.

I investigated this myself and apparently "opmode" is stopped when the
module is unloaded or the PCI device is removed. So just say that in the
commit log and everyone understand much better.

(No actions needed, just for future reference.)

-- 
Kalle Valo

  reply	other threads:[~2016-03-04 16:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 20:56 pull request: iwlwifi 2016-02-25 Grumbach, Emmanuel
2016-02-25 20:57 ` [PATCH 1/2] iwlwifi: mvm: inc pending frames counter also when txing non-sta Emmanuel Grumbach
2016-02-25 20:57 ` [PATCH 2/2] iwlwifi: mvm: Fix paging memory leak Emmanuel Grumbach
2016-03-04 16:07   ` Kalle Valo [this message]
2016-03-04 19:45     ` Luca Coelho
2016-03-06 12:03       ` Kalle Valo
2016-03-06 13:49         ` Grumbach, Emmanuel
2016-02-26 10:46 ` pull request: iwlwifi 2016-02-25 Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87povaw7jc.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=emmanuel.grumbach@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=matti.gottlieb@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).