From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0A6C433E0 for ; Wed, 17 Feb 2021 10:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18EB164DA1 for ; Wed, 17 Feb 2021 10:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232151AbhBQKGN (ORCPT ); Wed, 17 Feb 2021 05:06:13 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:62114 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232147AbhBQKGJ (ORCPT ); Wed, 17 Feb 2021 05:06:09 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1613556347; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=NACBgSaVoKefO4nYlVVRVr55kz4pXx2DcmCofVFHH7Q=; b=iuKlk5Iwfrby9n3iHus5pYG9oA/2UCe5q1nM2Q7BasSikE/+YTWZusFgiCsaQu7Az7zCznZU fgITaOvz6iUBo+ToVztdXxxQp4DFkdf7zLLir0WzujeHOFz1QbNuhmJEnxkks4PQ+2+5v+8J r4cDMgbdFhRXFKz4q/1cL62Fkr4= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 602cea58eb4f89cdf827e581 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 17 Feb 2021 10:05:12 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 19129C433C6; Wed, 17 Feb 2021 10:05:12 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id F2ABFC433C6; Wed, 17 Feb 2021 10:05:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F2ABFC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Johannes Berg Cc: Srinivasan Raju , mostafa.afgani@purelifi.com, "David S. Miller" , Jakub Kicinski , open list , "open list\:NETWORKING DRIVERS \(WIRELESS\)" , "open list\:NETWORKING DRIVERS" Subject: Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices References: <20200928102008.32568-1-srini.raju@purelifi.com> <20210212115030.124490-1-srini.raju@purelifi.com> Date: Wed, 17 Feb 2021 12:05:06 +0200 In-Reply-To: (Johannes Berg's message of "Fri, 12 Feb 2021 14:44:05 +0100") Message-ID: <87r1lfovql.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: >> +++ b/drivers/net/wireless/purelifi/Makefile >> @@ -0,0 +1,2 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +obj-$(CONFIG_WLAN_VENDOR_PURELIFI) := plfxlc/ > > Although this one doesn't do anything, so all you did was save a level > of Kconfig inclusion I guess ... no real objection to that. I think this should use obj-$(CONFIG_PLFXLC). -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches