From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9407CC2BB1D for ; Tue, 14 Apr 2020 06:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6139120678 for ; Tue, 14 Apr 2020 06:34:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="DBBAzz+9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406043AbgDNGeT (ORCPT ); Tue, 14 Apr 2020 02:34:19 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:34400 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406042AbgDNGeS (ORCPT ); Tue, 14 Apr 2020 02:34:18 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586846057; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=T7OoWyEzPwXRazzh9XBTXC4jr6oq9UVyd5x0NpZXrK4=; b=DBBAzz+9AXC5H7FkvQn/oHaE5XoIuUzViWiHMU5F6xVHU2pt5qBZ5PzemkUDndhl81SpJCb7 F2fgRR56xydxHFmwGIA9AtII3INKv7m4fOJHFbpuyOZ8fMxzEXjhKuA4GaFyIlEdzyNIkI4d RYTRm7GQ2gg5+dZBjtpq3r/Gu/U= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e955964.7f7bbc824260-smtp-out-n01; Tue, 14 Apr 2020 06:34:12 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1996BC43637; Tue, 14 Apr 2020 06:34:12 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 94148C433CB; Tue, 14 Apr 2020 06:34:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 94148C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, Soul Huang , Lorenzo Bianconi Subject: Re: [PATCH v2] mt76: mt7615: rework IRQ handling to prepare for MSI support References: <20200409181401.12070-1-nbd@nbd.name> Date: Tue, 14 Apr 2020 09:34:09 +0300 In-Reply-To: <20200409181401.12070-1-nbd@nbd.name> (Felix Fietkau's message of "Thu, 9 Apr 2020 20:14:01 +0200") Message-ID: <87r1wqlgny.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > With MSI interrupts, IRQs must not be enabled from within the IRQ handler, > because that can lead to lost events. > Defer IRQ processing to a tasklet, which is also responsible for enabling > IRQs (to avoid race conditions against the handler) > > Co-developed-by: Soul Huang > Acked-by: Lorenzo Bianconi > Signed-off-by: Felix Fietkau Soul's s-o-b is missing. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches