linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: nbd@nbd.name, sgruszka@redhat.com,
	linux-wireless@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] mt76: fix building without CONFIG_LEDS_CLASS
Date: Fri, 02 Nov 2018 13:33:58 +0200	[thread overview]
Message-ID: <87r2g3btnd.fsf@purkki.adurom.net> (raw)
In-Reply-To: <5d0d7286445acef822a806dc89fcbf9eb2672ade.1541150589.git.lorenzo.bianconi@redhat.com> (Lorenzo Bianconi's message of "Fri, 2 Nov 2018 10:32:32 +0100")

Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:

> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while
> mt76 is built-in, we run into a link error:
>
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_register_device':
> mac80211.c:(.text+0xb78): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_of_led_classdev_register'
>
> We don't really need a hard dependency here as the driver can presumably
> work just fine without LEDs, so this follows the iwlwifi example and
> adds a separate Kconfig option for the LED support, this will be available
> whenever it will link, and otherwise the respective code gets left out from
> the driver object.
>
> Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

Should this go to 4.20? A linker error is pretty bad, even though I
think this is few months old issue already.

And are conflicts with -next version of mt76 likely?

-- 
Kalle Valo

  reply	other threads:[~2018-11-02 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1541150589.git.lorenzo.bianconi@redhat.com>
2018-11-02  9:32 ` [PATCH] mt76: fix building without CONFIG_LEDS_CLASS Lorenzo Bianconi
2018-11-02 11:33   ` Kalle Valo [this message]
2018-11-02 13:20     ` Lorenzo Bianconi
2018-11-05 14:54       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2g3btnd.fsf@purkki.adurom.net \
    --to=kvalo@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).