linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH 01/13] rtlwifi: Replace old-style license information
Date: Sat, 09 Feb 2019 08:02:37 +0200	[thread overview]
Message-ID: <87tvhd33eq.fsf@codeaurora.org> (raw)
In-Reply-To: <20190208172209.28530-2-Larry.Finger@lwfinger.net> (Larry Finger's message of "Fri, 8 Feb 2019 11:21:57 -0600")

Larry Finger <Larry.Finger@lwfinger.net> writes:

> The traditional license information is replaced by the SPDX form. There
> are no code changes.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

[...]

> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -1,27 +1,5 @@
> -/******************************************************************************
> - *
> - * Copyright(c) 2009-2012  Realtek Corporation.
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.

So the way I see this is GPLv2 only (so GPLv3 is not included).

> +/* SPDX-License-Identifier: GPL-2.0+ */

But this is GPLv2 or later (including GPLv3 for example).
LICENSES/preferred/GPL-2.0 contains more info about the tags.

Also for SPDX tags in .c files you should use C++ comment style '//',
BUT in .h files normal C comment style '/* */'. Confusing, I know :/

https://www.kernel.org/doc/html/latest/process/license-rules.html#license-identifier-syntax

-- 
Kalle Valo

  reply	other threads:[~2019-02-09  6:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 17:21 [PATCH 00/13] rtlwifi: Replace old-style license info with SPDX form Larry Finger
2019-02-08 17:21 ` [PATCH 01/13] rtlwifi: Replace old-style license information Larry Finger
2019-02-09  6:02   ` Kalle Valo [this message]
2019-02-09  6:08     ` Kalle Valo
2019-02-08 17:21 ` [PATCH 02/13] rtlwifi: btcoex: " Larry Finger
2019-02-08 17:21 ` [PATCH 03/13] rtlwifi: rtl8188ee: " Larry Finger
2019-02-08 17:22 ` [PATCH 04/13] rtlwifi: rtl8192com: " Larry Finger
2019-02-08 17:22 ` [PATCH 05/13] rtlwifi: rtl8192ce: " Larry Finger
2019-02-08 17:22 ` [PATCH 06/13] rtlwifi: rtl8192cu: " Larry Finger
2019-02-08 17:22 ` [PATCH 07/13] rtlwifi: rtl8192de: " Larry Finger
2019-02-08 17:22 ` [PATCH 08/13] rtlwifi: rtl8192ee: " Larry Finger
2019-02-08 17:22 ` [PATCH 09/13] rtlwifi: rtl8192se: " Larry Finger
2019-02-08 17:22 ` [PATCH 10/13] rtlwifi: rtl8723ae: " Larry Finger
2019-02-08 17:22 ` [PATCH 11/13] rtlwifi: rtl8723be: " Larry Finger
2019-02-08 17:22 ` [PATCH 12/13] rtlwifi: rtl8723_common: " Larry Finger
2019-02-08 17:22 ` [PATCH 13/13] rtlwifi: rtl8821ae: " Larry Finger
2019-02-09  3:00 ` [PATCH 00/13] rtlwifi: Replace old-style license info with SPDX form Joe Perches
2019-02-09 21:03   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvhd33eq.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).